robinpowered / commodus Goto Github PK

Currently commodus will wait until a PR is opened or a PR comment is created until a status of the latest commit sha is set.

Anytime a new commit comes through, the status should be reset on that commit.

Lately it seems that GitHub has been autocompleting :+1: and :-1: into the proper unicode representations, instead of leaving the raw colon-delimited "GitHub emoji marks". This is great for a lot of reasons, namely the fact that the messages retrieved from the API actually contain proper, standard unicode symbols instead of "magic text".

Unfortunately, however, Commodus seems to be searching comment bodies for the literal :+1: and :-1: text, so therefore it doesn't recognizer the unicode symbols.

For convenience, here's the unicode code-points of these characters:

• 👍 = U+1F44D
• 👎 = U+1F44E

It would be useful to ensure that the same person didn't give the plus one twice.

It would also be sweet if someone could throw in a 👎 and it would subtract from the total count.

LBTM 👎

Actual Behaviour: If a GitHub user responds to a comment via email, and the (responded to) comment contains a plus one, Commodus parses it in the reply.

Expected Behaviour: Not to parse the +1 from the quoted text.

Noticed this behavior when closing a PR and reopening it. The 👍 counter will be deleted and we won't open a new one since a new PR technically hasn't been opened.

Perhaps we should rely on a merge hook instead of a close hook for PRs before deleting any data.

Currently there is no webhook for a user modifying their comment. Perhaps have the program parse all comments on every new comment push.