Giter VIP home page Giter VIP logo

omni-epd's Issues

Add Partial Update Support

If I have time, I can work on a solution, but in the meantime, I'm just going to add this here as a future feature request. Not sure if MissionFloyd wants to take a crack at it. I imagine that it could be another mode since only the bw/grey screens seem to support it.

Screens with official partial update support:

  • 1.02
  • 1.54
  • 2.13
  • 2.66
  • 2.9
  • 3.7
  • All IT8951 based HD screens

Review epd2in66b

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in66b.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in66b_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd7in5

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd7in5.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd7in5_V2.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_7in5_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_7in5_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd2in9

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in9.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in9_V2.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in9_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in9_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

clear() results in TypeError for WaveShare epd2in7

Display Type: waveshare_epd.epd2in7
Version pulled: 2021.05.08 Main Branch

The omni-epd-test and example code both successfully display rectangles and the nebula image respectively without issue.

Calling the clear() method on a displayfactory object raises a TypeError:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-21-7ef3a3b8a5ed> in <module>
----> 1 epd.clear()

~/.local/share/virtualenvs/epdlib-AIMLabQa/lib/python3.7/site-packages/omni_epd/displays/waveshare_display.py in clear(self)
     64         Most devices utilize the same clear function
     65         """
---> 66         self._device.Clear()
     67 
     68     def close(self):

TypeError: Clear() missing 1 required positional argument: 'color'

The root cause is that the epd2in7 B&W driver expects a color value. This is extra frustrating because the 2in7 doesn't even use the color value.

I've started rewriting the waveshare EPD drivers to clean up some of this mess, but there's so much inconsistency, copy/pasta, and lack of proper documentation that I haven't made much progress beyond the 2in7 and 5in83.

Minimal example:

import sys
from omni_epd import displayfactory, EPDNotFoundError
from PIL import Image

displayName = "waveshare_epd.epd2in7"
print('Loading display')
try:
    epd = displayfactory.load_display_driver(displayName)
except EPDNotFoundError:
    print(f"Couldn't find {displayName}")
    sys.exit()

# if now load an image file using the Pillow lib
print('Loading image')
image = Image.open('../PIA03519_small.jpg')
# resize for your display
image = image.resize((epd.width, epd.height))
# prepare the epd, write the image, and close
print('Writing to display')
epd.prepare()
epd.display(image)
epd.close()

epd.prepare()
epd.clear()
epd.close()

Couldn't find waveshare_epd.epd5in65f

Thanks for your development of this tool. I've implemented this in a project I'm working on. Previously was working with "waveshare_epd.epd7in5_V2", however I have tried to implement using a "waveshare_epd.epd5in65f". Official screen tests from waveshare work.

Receiving error on run for 'waveshare_epd.epd5in65f'
INFO:root:Couldn't find waveshare_epd.epd5in65f

When running displayfactory.list_supported_displays() I get a 'waveshare_epd.epd5in64f' in the list, which does not appear to be a valid name for a waveshare driver/product. When trying to run for waveshare_epd.epd5in64f as a test:
"waveshare_epd.epd5in64f not found, refer to install instructions"

Tried reinstalling waveshare package, no dice. Have tried to find where this error is occurring but I've not been able to dig too far into this code. Logging issue just in case it actually is an issue. As far as I can tell there may be a minor spelling error but can't find the text in the drivers or the code of this repo, really scratching my head about this one.

Extend INI file

A possible extension for the INI could allow for device specific parameters to be set for things that are device driver dependent. Examples of this include initialization parameters to set b/w vs grayscale for supported devices or pass in values like saturation for Inky Impression devices to the display() function. These are values that don't adjust the Image being passed to the display but instead configuration values on the display itself.

The way this would work is to define a device specific section in the ini file:

[omni-epd.mock]
grayscale=True

Implementing classes would be responsible for checking if these values exist and applying them accordingly. Advantages to this are that implementers can either bundle device specific configs with their projects per the global INI file; or users can modify them to their liking.

Review epd4in01f

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd4in01f.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_4in01f_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd2in7b

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in7b.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in7b_V2.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in7b_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in7b_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Inky Impression library doesn't work

I have followed the Pimoroni instructions w/ latest version (1.3.1) and installed Omni-epd with my Inky Impression color 5.7" display on raspberry pi 3 A+ and 4 B+, however the command omni-epd-test -e inky.impression does nothing. It doesn't update the display or output anything. However - if I run omni-end-test -e waveshare_epd.epd5in83 the screen will update.

more curious, the examples provided by Pimoroni (logo.py, stripes.py etc) will not work, but if I run omni-end-test -e waveshare_epd.epd5in83 immediately after, the screen will refresh with the aforementioned Pimoroni example image. Running it a second time will result in the screen drawing the squares as designed.

Simplify Display Testing

Simplify the display testing procedure of EPDTestUtility by using a console script when installed. This will remove the need for implementers to bundle test scripts themselves and then can use the built in function.

“Illegal instruction” when importing from `omni-epd` on Raspberry Pi Zero

Hi, sorry in advance for the silly question. Python deps are endlessly confusing to me, and I’m sure this is my fault 😖

Context:

I just went through the “Automated Installation” to set up SlowMovie on a Raspberry Pi Zero. When I tried to run python3 slowmovie.py to start the program, I got an “Illegal instruction” error. I traced it back to the following line:

from omni_epd import displayfactory, EPDNotFoundError

Minimal repro:

I isolated the above line into its own file and observed the same error.


I was able to get slowmovie.py working by swapping out omni_epd with waveshare_epd, following how it’s used in helloworld.py. But I figured that since you’re an active contributor to SlowMovie, you might be interested in this bug.

Happy to provide additional information if it would be helpful, just let me know! Cheers.

Review epd1in54b

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd1in54b.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd1in54b_V2.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_1in54b_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_1in54b_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Pillow Static Variables Changed

In version of Pillow 9.1.0 and greater several variables have changed related to image transformations. There are places in the omni-epd code that use the pre-9.1.0 variable names and are likely to throw an error as Pillow updates on new installs or upgrades to existing systems. To further complicate matters downstream libraries, like the IT8951 drivers, have already updated to work with the new variable names. This means pinning a specific version won't work as these libs will fail should someone try and load them.

Code related to the image transformations will need to be updated. Most of it (perhaps all) starts in the virtualepd.py file - https://github.com/robweber/omni-epd/blob/main/src/omni_epd/virtualepd.py#L89

Links

https://pillow.readthedocs.io/en/latest/releasenotes/9.1.0.html#constants

Config file

Many projects (like Python logging) allow for advanced config to be read in from a config file. This might be a good idea to allow users to define more advanced parameters for displays that don't necessarily need to be part of the VSMP implementers code. Examples of this would be display rotation or color formatting. This would allow for some sane defaults but if a user needed more advanced config for their purpose it isn't on the VSMP project to pass down these directives as part of their codebase.

only red pixels

Hi, I've got a waveshare_epd.epd2in7b_V2 that i'm trying to show a picture on.

when i configure the device for red mode using an ini file all I get is red pixels on the display, should it also display black?

e.g:
source image:
origonal
resized and converted to RBG:
converted
displayed:
rendered

Mock Display Palette with Dithering

This doesn't impact usability in a meaningful way but it is a shortcoming. When using the omni_epd.mock display in color mode the value of the palette_filter attribute returns the colors for black and white but no other colors.

The main effect this has is if you also try and apply a dither effect to the image when using the mock display. The dithering process expects this attribute to exist and have correct values. When testing this on a color image, applying a dither always results in a black and white image as that is the returned palette.

Since the mock display is really more of a testing tool it isn't a meaningful usability issue but will not yield correct results in it's current form.

Issues with a fix

A simple fix for this wasn't evident at first glance. The dithering code is triggered when display() is called within the parent VirtualEPD class prior to the display implementation method _display() being called. As a result the effect is already applied before the specific device class has access to the Image. Because this is a parent class function it's not easy to code around this by simply importing the palette of the Image object. There are other displays that use color as their mode that do set a proper palette correctly from the device driver.

Workarounds

Not really a workaround but if no fix can be found I think it would be ok to simply document this as a shortcoming and leave it as is. It's not really a show stopper as it doesn't effect actual devices.

Issue with 3.7 in Waveshare

From @ZubaZ21

I love the idea of abstracting this. Very cool.

Pulled it down and ran the test util.
It threw an error.
File
"/usr/local/lib/python3.7/dist-packages/omni_epd/displays/waveshare_display.py",
line 251, in prepare
self._device.init()
TypeError: init() missing 1 required positional argument: 'mode'

I added a 0 so it became self._device.init(0) as that is what the waveshare
driver requested.

Fired it off again and got the following.

pi@GeneralPie:~ $ omni-epd-test -e waveshare_epd.epd3in7

Loaded waveshare_epd.epd3in7 with width 280 and height 480
Drawing rectangle of width 210.0 and height 360.0
Drawing rectangle of width 105.0 and height 180.0
Drawing rectangle of width 26.25 and height 45.0
Traceback (most recent call last):
File "/usr/local/bin/omni-epd-test", line 10, in
sys.exit(main())
File "/usr/local/lib/python3.7/dist-packages/omni_epd/test_utility.py",
line 127, in main
test.draw()
File "/usr/local/lib/python3.7/dist-packages/omni_epd/test_utility.py",
line 85, in draw
self.__draw_on_display(im)
File "/usr/local/lib/python3.7/dist-packages/omni_epd/test_utility.py",
line 67, in __draw_on_display
self.epd.display(image)
File "/usr/local/lib/python3.7/dist-packages/omni_epd/virtualepd.py",
line 202, in display
self._display(self.__applyConfig(image))
File
"/usr/local/lib/python3.7/dist-packages/omni_epd/displays/waveshare_display.py",
line 263, in _display
self._device.display(self._device.getbuffer(image))
AttributeError: 'EPD' object has no attribute 'display'

Let me know if you need further testing.

Aaron

More Complex Examples

Update the examples for more complicated use cases. Primary ones would be:

  1. Setting individual display to either b/w or color
  2. Passing device specific args (requires #9)
  3. Setting a custom color palette

Review epd2in13d

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in13d.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in13d_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd4in2bc

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd4in2bc.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd4in2b_V2.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_4in2bc_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_4in2b_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Waveshare 7.8in HAT support?

Don’t know if this is the right place to ask, but is there any chance to support the waveshare 7.8in HAT screen at all?

https://www.waveshare.com/wiki/7.8inch_e-Paper_HAT

I would love to replace my Rasp Pi 4b / 7in5_V2 screen (which works perfectly) with this higher res screen that I bought months ago but I haven’t got anywhere with waveshare directly. They have no plans to support their own screen in the python library -

“I'm sorry that we don't have a plan to release a python driver for the library, since the speed of the parallel port screen is too slow if you use python to refresh it.”

I don’t understand the answer (I’m a beginner following instructions), but hoped someone here could help.

Individual EDP instructions

It's almost impossible to bundle all the right libraries for each type of EPD. Many have additional OS requirements (installed with apt-get or similar) or python libraries that need to be built by hand.

Define a place in the documentation that links to each display type's library setup instructions and explain that these need to be part of implementing projects.

Review epd1in54c

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd1in54c.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_1in54c_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd2in9bc

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in9bc.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in9b_V3.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in9bc_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in9bc_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

clear() results in TypeError for WaveShare epd2in13_V2

Display Type: waveshare_epd.epd2in13_V2
Version pulled: 2022.03.29 Main Branch

> from omni_epd import displayfactory
> epd = displayfactory.load_display_driver("waveshare_epd.epd2in13_V2")
> epd.prepare()
> epd.clear()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "$CONDA_PATH/lib/python3.9/site-packages/omni_epd/displays/waveshare_display.py", line 139, in clear
    self._device.Clear()
TypeError: Clear() missing 1 required positional argument: 'color'

I read the issue #19 about this error, and could not solve it. The epd2in13_V2 display is not declared as a device that needs an alternate clear() function, but it should.

I tried to fix this by changing the following line

"epd2in13_V2": {"alt_init": True, "lut_init": False, "alt_clear": False, "version": 2},

to

"epd2in13_V2": {"alt_init": True, "lut_init": True, "alt_clear": True, "version": 2},

but it did not work and I got the same error.

Review epd7in5_HD

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd7in5_HD.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_7in5_HD_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd4in2

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd4in2.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_4in2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd1in54

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd1in54.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_1in54_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_1in54_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd1in02

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd1in02.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_1in02_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd7in5b_HD

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd7in5b_HD.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_7in5b_HD_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd2in13bc

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in13bc.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in13b_V3.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in13bc_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in13b_V3_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd2in66

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in66.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in66_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd5in65f

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd5in65f.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_5in65f_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Inky BW inversion problem

Seems that #61 introduced an issue with Inky displays in BW mode. Prior to that fix Inky models used black as the color mode instead of bw. This caused images in that mode to use palette based color filtering with a palette. By fixing the mode it now triggers the conditional to convert the image to using convert(mode=1). For some reason having the image in this mode causes the black and white pixels to be inverted when drawn to the display.

In hindsight this was working correctly, but only because the code block that should have been triggered was actually missed. Inky seems to respond correctly by having the image in P mode.

Review epd2in13

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in13.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in13_V2.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in13_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in13_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd5in83

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd5in83.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd5in83_V2.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_5in83_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_5in83_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd2in7

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in7.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in7_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd7in5bc

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd7in5bc.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_7in5bc_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd3in7

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd3in7.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_3in7_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Review epd2in9d

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd2in9d.py
Example code: https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_2in9d_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Waveshare 7.8 display

I have been running SlowMovie player on a 7.5 inch Waveshare display but wanted to try it on the 7.8. the only change I made was to set epd = waveshare_epd.it8951 and remove the other epd display from the conf file. When I run the program nothing displays on the 7.8 and I get the following;

Traceback (most recent call last):
File "/home/pi/SlowMovie/slowmovie.py", line 251, in
epd = displayfactory.load_display_driver(args.epd)
File "/home/pi/.local/lib/python3.9/site-packages/omni_epd/displayfactory.py", line 113, in load_display_driver
result = classObj(deviceType[1], config)
File "/home/pi/.local/lib/python3.9/site-packages/omni_epd/displays/waveshare_display.py", line 404, in init
self._device = deviceObj.AutoEPDDisplay(vcom=self._getfloat_device_option('vcom', -2.06),
File "/home/pi/.local/lib/python3.9/site-packages/IT8951/display.py", line 227, in init
AutoDisplay.init(self, self.epd.width, self.epd.height, **kwargs)
File "/home/pi/.local/lib/python3.9/site-packages/IT8951/display.py", line 26, in init
self._set_rotate(rotate, mirror)
File "/home/pi/.local/lib/python3.9/site-packages/IT8951/display.py", line 69, in _set_rotate
'CW' : Image.Transpose.ROTATE_270,
File "/home/pi/.local/lib/python3.9/site-packages/PIL/Image.py", line 65, in getattr
raise AttributeError(f"module '{name}' has no attribute '{name}'")
AttributeError: module 'PIL.Image' has no attribute 'Transpose'

Any ideas what is going wrong?

thanks,
Tom

Review epd5in83bc

Review the function calls for the Waveshare device and make sure the omni-epd abstraction uses the right methods, with the right parameters based on the library and example code. Any modifications should be patched in a PR referencing this issue.

Library file:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd5in83bc.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/lib/waveshare_epd/epd5in83b_V2.py
Example code:
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_5in83bc_test.py
https://github.com/waveshare/e-Paper/blob/master/RaspberryPi_JetsonNano/python/examples/epd_5in83b_V2_test.py

Things to check:

  • init() method
  • display() method
  • clear() method
  • sleep() method

Black vs BW

I noticed when looking through things that some devices use bw as they default mode identifier while others use black. It's more of a semantic difference but sticking with a single identifier across all types would be more consistent. There are also areas in the parent virtualepd.py class where it checks specifically for bw as a string before applying certain functions.

Might be worth the effort of defining some constants for comparisons as well as consistency.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.