Giter VIP home page Giter VIP logo

liferay-ckeditor's Introduction

liferay-ckeditor

This is a fork of the ckeditor-dev repository.

Building

To build a production-ready build, use:

./build-ckeditor.sh $CKEDITOR_VERSION

Where $CKEDTIOR_VERSION is a valid tag in the CKEDITOR repository, such as "4.11.3".

If you'd rather like a development build, for example for local debugging, use:

env DEBUG=1 ./build-ckeditor.sh $CKEDITOR_VERSION

The build files will be generated in the ckeditor directory.

WARNING: You should never publish development builds to the npm registry.

Testing in liferay-portal

To test your local CKEditor build in liferay-portal:

  1. Navigate to the frontend-editor-ckeditor-web module
  2. Run yarn add $PATH_TO_LOCAL_LIFERAY_CKEDITOR_REPO
  3. Re-deploy the module with gradlew clean deploy.

Publishing

After successfully building and testing you can publish to NPM.

# Confirm that worktree is clean and up-to-date.
git checkout master
git pull upstream master --ff-only
git status

# Bump the version number, creating a commit and tag.
# See below for notes on the format of the version number.
npm version $VERSION

# Sanity check what will be published.
npm publish --dry-run

# Publish to GitHub.
git push upstream master --follow-tags

# Publish to NPM.
npm publish

Choosing a version number

For tagging and publishing $VERSION should be of the form $CKEDITOR_VERSION-liferay.$RELEASE. For example, "4.11.3-liferay.1"; that is:

  • Based on CKEditor 4.11.3.
  • Release number 1.

Subsequent releases would be "4.11.3-liferay.2", "4.11.3-liferay.3" and so on. When we update to CKEditor 4.11.4, we reset the suffix, so the release would be "4.11.4-liferay.1", "4.11.4-liferay.2" and so on.

WARNING: You should never publish development builds to the npm registry.

Updating CKEditor in liferay-portal

To update CKEditor in liferay-portal:

  1. Navigate to the frontend-editor-ckeditor-web module
  2. Update the liferay-ckeditor dependency in the package.json file
  3. Re-deploy the module with gradlew clean deploy.

An example of this can be seen in this commit (look at the package.json file)

Patching

  • Make sure you're update to date with the superproject repository:

     git pull origin master
  • Set up everything to start working on a patch:

     sh ck.sh setup
  • Work on your changes:

    cd into the ckeditor-dev/ submodule and prepare your desired changes on the liferay branch.

    This could be cherry-picking a previously created commit or manually editing a file, so this can't be automated.

  • Create your commit, add your changes and write a good commit message.

  • Navigate back to the superproject's root directory and create the patch:

     cd ..
     sh ck.sh patch
  • Create a build of CKEditor containing the patches:

    From the root of the superproject's directory, run

     sh ck.sh build
  • Don't forget to add the changes and commit

liferay-ckeditor's People

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.