Comments (9)
I added some sort of timeout system in r563. It still needs some testing.
Also, the check is done only when someone tries to login.
Original comment by [email protected]
on 17 Dec 2010 at 2:08
- Changed state: Accepted
from nullpomino.
this indeed needs more testing, would be good if we can get this fixed for 7.5
I set the value to 5 sec, which seems reasonable - which causes random
disconnects, directly in the middle of actually playing 40L games on netplay.
I'll keep it at 5000 for now, that you can debug this.
Original comment by [email protected]
on 5 Jan 2011 at 12:17
from nullpomino.
ok I tested some more and saw in the server logs that these random disconnects
seem to be realted to new players login in the server, e.g.:
00:36:44,196 [main] INFO NetServer: Logout: **ip**
00:36:44,196 [main] INFO NetServer: xlro !NANNANNANA has logged out
00:36:44,215 [main] INFO NetServer: RoomDelete ID:18 Title:Single:LINE RACE
00:36:44,224 [main] INFO NetServer: Logout: **ip**
00:36:44,224 [main] INFO NetServer: Cedevita has logged out
00:36:44,224 [main] INFO NetServer: Killed 2 dead connections
00:36:44,226 [main] INFO NetServer: Paradox !botJudpywY has logged in
(Host:**ip** Team:)
00:36:44,981 [main] INFO NetServer: Hyper Zircean !Ya.GWW5jkg has logged in
(Host:**ip** Team:)
I will increase the timeout delay now till the issue doesnt show up anymore,
since the server is not playable like this, as soon as someone joins others get
dropped
let me know if you want to debug this on nullpo.it.cx, then I can change the
settings for you
Original comment by [email protected]
on 5 Jan 2011 at 12:40
from nullpomino.
just to note and rule out any coincidences: I also increased
netserver.maxLobbyChatHistory and netserver.maxRoomChatHistory when I lowered
netserver.timeoutTime
Original comment by [email protected]
on 5 Jan 2011 at 12:47
from nullpomino.
5 seconds? That's too short.
Currently NullpoMino sends a ping message every 10 seconds. So
random-disconnection will happen if you set the timeout below 10 seconds.
Maybe we should set ping interval to 5 or less seconds?
Original comment by [email protected]
on 5 Jan 2011 at 11:23
from nullpomino.
okay, I was under the impression from the description that the timeoutTime
value defined the ping/pong interval and that this is not hardcoded. Maybe add
it as another config value? 5 sec makes sense to me, I have it set to 10 atm,
and it seems to work ok. But giving this value to the server admin to control,
is pbbly best.
Original comment by [email protected]
on 5 Jan 2011 at 1:08
from nullpomino.
That's a good idea.
I added server-controlled Ping interval option in r618. Please try it.
Original comment by [email protected]
on 5 Jan 2011 at 2:12
from nullpomino.
ok great, updated the server to r618, running with
netserver.timeoutTime=15000
netserver.clientPingInterval=5000
now for testing - looks ok so far.
Original comment by [email protected]
on 5 Jan 2011 at 2:38
from nullpomino.
Original comment by [email protected]
on 21 Jan 2011 at 3:26
- Changed state: Fixed
from nullpomino.
Related Issues (20)
- Something wrong when you fail to connect. HOT 1
- Soft drop fix was never looked at again after it was removed HOT 1
- screen is black HOT 6
- GIVEUP is triggered when a Multimedia key is pressed. [LWJGL Input] HOT 12
- Team Colors HOT 3
- Hold next frame/border improvements HOT 2
- Changing rule while on netplay does not actually change rule HOT 2
- Some buttons in lobby are not visible if lobby window is too small HOT 6
- 1on1 view not applied when joining 1on1 game in progress HOT 1
- Field grid is not displayed in slick and swing version HOT 3
- Game tuning and keyconfig accessible from lobby window HOT 1
- better win count display HOT 5
- next in big mode too big
- input from pause menu goes into game
- airankstool crash on start HOT 4
- people can't get ready in netplay to work HOT 4
- garbage meter in fractional garbage sometimes temporary disappears
- setting ; and ' keys does not work in slick.bat HOT 8
- Spectators cannot see field of player who is using big pieces HOT 3
- [NetServer] LinkedList: ConcurrentModificationException HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nullpomino.