Giter VIP home page Giter VIP logo

Comments (7)

Jackymancs4 avatar Jackymancs4 commented on May 20, 2024

I'm experiencing the very same problem on Chrome and I was already looking into it.
Firefox on the other side does not complain. Can you show me the steps to get what the screenshot shows?

Besides, if you can wait a couple hours I'll come back with a solution, if not I suggest releasing a 1.3.1 hotfix in which you revert b3613eb

from side-auto_sci-hub.

Jackymancs4 avatar Jackymancs4 commented on May 20, 2024

If you prefer, I can submit you a raster of logo.svg in png to use as a filler.

from side-auto_sci-hub.

RoiArthurB avatar RoiArthurB commented on May 20, 2024

Besides, if you can wait a couple hours I'll ...

Don't worry, take your time, I'm reverting to the previous version on chrome and leaving it on firefox cause it's still working ^^

Can you show me the steps to get what the screenshot shows?

It's simply when I'm uploading a plugin on Ff it analyze the code and dislay warnings and errors (as a normal compilator), that's all (nothing more sorry :x )

If you prefer, I can submit you a raster of logo.svg in png to use as a filler.

I know nothing about images on plugins (and not much about plugins neither...) so up to you ^^ You're the designer of the plugin and I'll let you do it as you prefer πŸ˜„

from side-auto_sci-hub.

RoiArthurB avatar RoiArthurB commented on May 20, 2024

Even with just the revert commit it doesn't fix the issue for chrome... So I'll upload back to the v1.1 ^^

Also, I took an eye on the svg code and there's a lot of inkscape code... Couldn't you create a minified export or something without InkS. tags? πŸ€”

from side-auto_sci-hub.

Jackymancs4 avatar Jackymancs4 commented on May 20, 2024

It's simply when I'm uploading a plugin on Ff it analyze the code and dislay warnings and errors (as a normal compilator), that's all (nothing more sorry :x )

No problem, I was able to replicate the message using https://github.com/mozilla/web-ext and https://github.com/mozilla/addons-linter (the problem arise here https://github.com/mozilla/addons-linter/blob/a5b46c52d125c09324a1cbc36d81f5438c622777/src/parsers/manifestjson.js#L511)

The apparent corruption is indeed caused by the odd xhtml notation used by the last version of inkscape (never been a problem before). It is fixable.

Unluckily, due to this outstanding bug (https://bugs.chromium.org/p/chromium/issues/detail?id=29683) SVG icons are not an option at all for Chrome.

It is my fault, I should have checked before. All my works on web extensions are always been on the Firefox platform, so today I learned something.

from side-auto_sci-hub.

Jackymancs4 avatar Jackymancs4 commented on May 20, 2024

If you still like my design, I will replace all svg with png files, exported on the right resolution. Still, I'm sorry for wasting your time πŸ˜…

from side-auto_sci-hub.

RoiArthurB avatar RoiArthurB commented on May 20, 2024

It is my fault, I should have checked before. All my works on web extensions are always been on the Firefox platform, so today I learned something.

It's okay, don't worry ^^ The best point is that you learned something ^^

If you still like my design

Of course I love Squircled icons 😍

sorry for wasting your time

You don't I learned some things with all your links ! It was a pleasure to received your help ^^

from side-auto_sci-hub.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.