When i open a article website, and then click the auto-sci-hub. The page will becomes a blank and Can't open the article pdf page

Describe the bug
I cannot change the base URL. Denmark has recently started blocking the Swedish and the Taiwan domains (.se, .tw), but the .shop one works. So I want to use that.

To Reproduce
Steps to reproduce the behavior:

1. Go to extension preferences
2. Click on enter any url (e.g. http://sci-hub.shop/)
3. Click save
4. Nothing happens, it keeps using the old one which results in waiting forever sense .se domain is blocked

Expected behavior
I expect it to use the new base URL

Screenshots

Desktop (please complete the following information):

• OS: Linux Mint
• Browser Firefox
• Version 71.0 (64-bit)

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

I don't really know whether to post this issue here or on whereisscihub project, since it is used to get redirected to the actual sci-hub page, but I'll explain briefly.

Since ACM DL website uses a GET parameter to identify articles on their website (example: https://dl.acm.org/citation.cfm?id=2803202 ), where using whereisscihub to be redirected on the current sci-hub location the GET parameter doesn't get forwarded to the actual sci-hub webpage.

Steps to reproduce the issue

1. Open any paper page hosted on ACM DL website (you can take the link in the example above)
2. Use the extension button
3. Get redirected to whereisscihub website (in the previous example it took me to https://whereisscihub.now.sh/go/https://dl.acm.org/citation.cfm?id=2803202 )
4. Get redirected automatically to https://sci-hub.se/https://dl.acm.org/dl.cfm , regardless the paper you requested (sci-hub base url may be different depending on which version is used by whereisscihub).

PS: I am currently using Firefox as browser. Don't know if this issue applies to other browsers.

Describe the bug
Click auto sci-hub on every link will give a wrong url, which loses a leading "h".

To Reproduce
Steps to reproduce the behavior:
If you click auto sci-hub in latest firefox:
https://www.sciencedirect.com/science/article/abs/pii/S0927050789010054
The url in new tab is
https://sci-hub.se//ttps%3A%2F%2Fwww.sciencedirect.com%2Fscience%2Farticle%2Fabs%2Fpii%2FS0927050789010054
without a leading 'h'.

Expected behavior
The url in new tab should be
https://sci-hub.se//https%3A%2F%2Fwww.sciencedirect.com%2Fscience%2Farticle%2Fabs%2Fpii%2FS0927050789010054

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows 10 1909
• Browser : Firefox
• Version : 71.0 (64-bit)

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

I sometimes use this extension while I have a lot of tabs open, but (in Firefox at least), the new tab opened by clicking the extension icon appears at the end of my tab list instead of after my current tab. Putting the Sci-Hub tab directly after the tab that spawned it would keep relevant tabs next to each other and would be more consistent with Firefox's Open Link in New Tab.

@Jackymancs4 I'm wondering about the choice of Page Action v Browser Action... 🤔 🤔

I mean, it looks absurd to have the plugin as a page action if it apply on every page.. It turns to be a Browser action finally, or in my sense it does 🤔

I wanted to have your point of view on that, what do you think?

Describe the bug
When pressing Open in Sci-Hub while in a Private Browsing tab on Android, it opens in a non-Private tab.

To Reproduce
Steps to reproduce the behavior:

1. Load a journal article page in Private Browsing on Firefox Android
2. Open menu and click Open in Sci-Hub

Expected behavior
Sci-Hub opening in a Private Tab next to the current one.

Smartphone (please complete the following information):

• Device: Samsung Galaxy S10+
• OS: Android
• Browser: Firefox
• Version: 68.4.2

Auto SciHub on Firefox 71 Windows 10

on this site https://science.sciencemag.org/content/366/6464/447 if you click AutoSciHub icon in Firefox it will attempt to open in a new tab

https://sci-hub.se//ttps%3A%2F%2Fscience.sciencemag.org%2Fcontent%2F366%2F6464%2F447

This url is incorrect since it is missing the h in https and the page will not open.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
Hello,
I just would like to report a bug occuring in my case.
When i click on the addons, the new tab opens well, but it does not work because it is missing a "h" to the URL:
For example:
"https://186.2.163.90//ttps%3A%2F%2Fwww.sci etc.."

I do not know if this is normal? What should I do to solve this problem?

Thank you a lot for this great addons! and in advance for your reply

Describe the bug
@Jackymancs4 The SVG is corrupted and Firefox give me some warnings about it and the plugin is impossible to install on chrome because of the SVG file...

I don't know how it works so can you help me with it?
The screenshot below is the firefox message (it's not much but it's all what I have) ^^"

Screenshots

Desktop (please complete the following information):

• Browser Chrome & Firefox
• Version 1.3

Could be nice to trigger the action with a keyboard shortcut :)

https://chrome.google.com/webstore/detail/auto-sci-hub/nlogbpfgpkffmombiknfdoogphkimmmd

This is a wonderful tool. But it cannot work in my chrome browser. When I click the extension of 'Auto Sci-hub' at the pape of one paper, the URL of this paper cannot be modified to DOI and hence, this paper cannot be downloaded.

For example, when I click this extension at the page https://www.osapublishing.org/ol/abstract.cfm?uri=ol-37-3-353, I only get this message 'Journal article not found. You can browse or search our database of articles.' However, if I use the DOI of this paper at sci-hub.se, this paper can be downloaded.

So it seems that the URL cannot be modified to DOI by this extension.

From @Clef-0

As an aside, for Firefox users, it looks like you can submit addons to AMO to be signed without listing them on AMO (see 'How do I get my add-ons signed if they are not hosted on addons.mozilla.org (AMO)?'), which would let you auto-update the addon outside of AMO and let users install it non-temporarily, and it appears to be an automated review process that they claim won't be used for copyright enforcement. I don't use AMO, so I don't know the details, but their instructions sound pretty straight forward and it would be make the addon convenient for Firefox users again.

Hi,

The extension is useful, but I always have to manually discard the tab from where it is launched. I think an useful improvement would be to add a checkbox option in the preferences, allowing one to open the link in scihub and also auto-close the current tab with a single click. Another way of doing it would be to simply load the sci-hub page in the current tab.

Thanks for your great plugin.

[GOT FROM MAIL] @shanelindsay

Hi

I could run your sci hub plug in on Chrome as it is disabled when installed from the .crx file:

"This extension is not listed in the Chrome Web Store and may have been added without your knowledge"

However, I got it to work with some google fu

• open crx using a zip program and unpack
• change folder name to remove _ (as Chrome doesn't like it)
• remove _ from config.yml (as Chrome doesn't like it)
• install as unpacked extension

(see truedread/netflix-1080p#68 for how I figured this out)

So perhaps worth adding these instructions on your page here https://github.com/RoiArthurB/Side-Auto_Sci-Hub to get round this (and change file/folder names if possible).

Thanks for the extension!

Best wishes,

Shane

Describe the bug
Link to https://addons.mozilla.org/en-US/firefox/addon/auto-sci-hub/ is broken

To Reproduce
Click link

Expected behavior
I want a way to download the extension

Screenshots

Hello @RoiArthurB
I've been following the recent updates and discussions.

I was wondering if you can consider to do (or accept a PR that does) what the title says.

Technically speaking, including and adapting this

async function getUrls() {
  const sciHubId = 'Q21980377';
  const officialWebsiteProperty = 'P856';
  const sparql = `
    SELECT ?urls WHERE {
      { wd:${sciHubId} p:${officialWebsiteProperty} [wikibase:rank wikibase:PreferredRank; ps:${officialWebsiteProperty} ?urls]. }
    }
    `;
  const response = await fetch(`https://query.wikidata.org/sparql?format=json&query=${encodeURIComponent(sparql)}`);
  const data = await response.json();

  const urls = data.results.bindings.map(result => result.urls.value);

  return urls.sort(compareUrls);
}

function compareUrls(url1, url2) {
  // URL beginning with `https://`, and ending in a non-digit character (of the TLD) and a potential trailing slash
  const httpsDomainRE = /^https:\/\/(.*)\D\/?$/;
  // URL beginning with `http://`, and ending in a non-digit character (of the TLD) and a potential trailing slash
  const httpDomainRE = /^http:\/\/(.*)\D\/?$/;

  // Regular URL's pointing to an HTTPS address come first
  if (httpsDomainRE.test(url1)) {
    return -1;
  } else if(httpsDomainRE.test(url2)) {
    return 1;
  // IP addresses using HTTPS come second
  } else if(url1.substr(0, 5) === 'https') {
    return -1;
  } else if(url2.substr(0, 5) === 'https') {
    return 1;
  // Only then come regular domains hosted through naked HTTP
  } else if(httpDomainRE.test(url1)) {
    return -1;
  } else if(httpDomainRE.test(url2)) {
    return 1;
  }
  // And if both are an IP address through naked HTTP, we don't care which comes first:
  return 0;
}

taken from https://gitlab.com/Flockademic/whereisscihub/blob/master/index.js

From what I understand from here you already considered it.

The problem is that if I explicitly gather SH URLs in the plugin I'm afraid to not respect the Firefox's rules and having my plugin being struck :/

I think this is not a real problem, mainly because from a functional standpoint, what you would already do is redirect to sci-hub, just with a middle step.

Also, on the market there are other Sci Hub related extensions (namely https://addons.mozilla.org/firefox/addon/open-on-sci-hub) that literally hard-code the URLs and have been around for quite some time.

Right now, you are quite reliant on the maintenance of whereisscihub (even when the option-thing will be released, which is a great idea, someone will have to keep the code working and consistent the actual behaviour).

This idea should give you quite some independence, and relieve you from the burden of also maintaining server-side whereisscihub forks (which you are doing now).

From mail :

Name: Anon
Email: [email protected]

Message:
Dear Arthur!
At first, thank you for your "Auto Sc-Hub" extension, it is really musthave stuff. Unfortunately, now Mozilla is not what it was before & I think that Pale Moon is a good choice now. But it doesn't support WebExtensions. It will be great, if in future you can add PM-version of addon in your / or PM repository. Now there are no anyone Sci-Hub add for PM, it's sadly.
Best wishes!