rombert / ereviewboard Goto Github PK
View Code? Open in Web Editor NEWA mylyn-based Eclipse integration for Review Board
A mylyn-based Eclipse integration for Review Board
Investigate what Gerrit is doing and do the same.
Just check what Gerrit is doing and do the same.
The new REST API has limits in place for retrieving almost every entity. We should make sure to use the paging calls, otherwise we will start missing data.
!ENTRY org.eclipse.mylyn.tasks.ui 4 0 2011-03-08 13:22:34.488
!MESSAGE
!STACK 0
java.lang.NullPointerException
at org.eclipse.jface.wizard.WizardDialog.updateButtons(WizardDialog.java:1326)
at org.review_board.ereviewboard.ui.wizard.ReviewboardQueryPage$UpdateButtonsListener.handleEvent(ReviewboardQueryPage.java:557)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1282)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1263)
at org.eclipse.swt.widgets.Combo.select(Combo.java:1840)
at org.review_board.ereviewboard.ui.ReviewboardUiUtil.selectDefaultComboItem(ReviewboardUiUtil.java:62)
at org.review_board.ereviewboard.ui.wizard.ReviewboardQueryPage.createControl(ReviewboardQueryPage.java:402)
at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:170)
at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:734)
at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:606)
at org.eclipse.jface.window.Window.create(Window.java:431)
at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1089)
at org.eclipse.mylyn.internal.tasks.ui.actions.NewQueryAction.run(NewQueryAction.java:97)
at org.eclipse.mylyn.internal.tasks.ui.actions.NewQueryAction.run(NewQueryAction.java:59)
at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3540)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3161)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:620)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
at org.eclipse.equinox.launcher.Main.run(Main.java:1408)
at org.eclipse.equinox.launcher.Main.main(Main.java:1384)
We should instead refer to the Mylyn update site as an associate site, if needed.
Improvement: it should be possible to close a review request and commit in one operation.
One should also have the possibility to link review request and commit:
Instead, they are preset to the original values
The current change detection is incorrect - a change is show twice and opening the task editor shows that the task has incoming changes, but it doesn't.
Apparently the result is received partially . One suspect is incorrect synchronisation - perhaps multiple threads read from the same result. Another possibility is that the result is not completely read and the next reader gets bad data.
org.review_board.ereviewboard.core.exception.ReviewboardException: The server has responded with an invalid JSon object : A JSONObject text must begin with '{' at character 1
": "Bla Bla", "id": 861}, {"status": "submitted", "last_updated": "2011-07-28 13:42:07", "description": "Bla bla bla bla bla", "links": {"diffs"...
at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.readReviewRequests(RestfulReviewboardReader.java:189)
at org.review_board.ereviewboard.core.client.RestfulReviewboardClient$7.doLoadInternal(RestfulReviewboardClient.java:268)
at org.review_board.ereviewboard.core.client.PagedLoader.doLoad(PagedLoader.java:64)
at org.review_board.ereviewboard.core.client.RestfulReviewboardClient.getReviewRequests(RestfulReviewboardClient.java:273)
at org.review_board.ereviewboard.core.ReviewboardRepositoryConnector.performQuery(ReviewboardRepositoryConnector.java:491)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQuery(SynchronizeQueriesJob.java:311)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQueries(SynchronizeQueriesJob.java:268)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.run(SynchronizeQueriesJob.java:201)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeRepositoriesJob.updateQueries(SynchronizeRepositoriesJob.java:186)
at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeRepositoriesJob.run(SynchronizeRepositoriesJob.java:142)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: org.review_board.ereviewboard.core.exception.ReviewboardException: The server has responded with an invalid JSon object : A JSONObject text must begin with '{' at character 1
": "Bla Bla", "id": 861}, {"status": "submitted", "last_updated": "2011-07-28 13:42:07", "description": "Bla bla bla bla bla", "links": {"diffs"...
at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.checkedGetJSonRootObject(RestfulReviewboardReader.java:112)
at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.readReviewRequests(RestfulReviewboardReader.java:178)
... 10 more
Caused by: org.json.JSONException: A JSONObject text must begin with '{' at character 1
at org.json.JSONTokener.syntaxError(JSONTokener.java:496)
at org.json.JSONObject.(JSONObject.java:180)
at org.json.JSONObject.(JSONObject.java:403)
at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.checkedGetJSonRootObject(RestfulReviewboardReader.java:99)
... 11 more
It's not used anywhere
During Repository setup, When I "Validate Settings" to my company's Review Board server, I get this error:
"Did not find session cookie in response"
Browser based access from the same client machine to the same server works fine.
What does that mean? How can I diagnose?
I mean, it's clear that this is where the error happens:
// look for session cookie
for (Cookie cookie : httpClient.getState().getCookies())
if (cookie.getName().equals("rbsessionid"))
foundSessionCookie = cookie.getValue();
if ( foundSessionCookie == null )
throw new ReviewboardException("Did not find session cookie in response");
but...why?
Possibly related: On some machines, (Firefox on Windows 7 in my office), I can't browse into ReviewBoard, because the server reports an error that my browser is not accepting cookies.
Chrome on the same machine can log in fine, though.
On the machine (Mac OS X 10.6,) where I am running Eclipse (Helios), though, logging in and out with Firefox works with no problems.
I have no Proxy set up, but I am connecting to the server via a VPN
If I close an issue from the Web UI it is not reflected in the task list. If I perform a manual sync of the query that it is correctly marked as closed.
The diff has an optional message, and we should display that.
Rather, it should be mapped to ''.
We should only allow access for 1.5 or higher servers.
The latest build does not have the 'Open in browser' editor icon. Neither is the menu item available.
We already have the private part.
All diffs should be visible in the list, with all but the most recent one being marked as obsolete.
This should be 1.0.0 all over, including in the feature descriptions.
In the teams view, repositories are listed under the unknown category.
On the gh-pages, upload the latest stable version.
It's important enough to display visibly.
http://www.reviewboard.org/docs/manual/1.5/webapi/2.0/resources/file-diff/ indicates how we can obtain file diffs,either as patches or as very detailed diffs.
It remains to be seen how we can hook into the compare ui. One possibility is to start from the org.eclipse.compare.internal.core.patch.PatchReader and work our way towards using org.eclipse.compare.internal.patch.PatchCompareEditorInput . The obvious problem is that these are internal classes.
I added ereviewboard plugin to my Eclipse workspace. Installation went fine.
However, While adding Task Repository, I added server details. When we click "Validate Settings" command button, It tries to connect to the server and gives the following error:
"The server has responded with an invalid JSon object : A JSONObject text must begin with '{' at character 1"
"Next" button is never enabled.
I can login to my reviewboard account using my credentials from a web browser.
Please let me know, is this a bug or I am making some mistake in configuration.
Is there any workaround for this problem?
Thanks
Aakash
Make sure that installation from the Marketplace client is functional with a fresh 'Eclipse for Java developers' installation.
We are not setting max-results, which means that for repositories with >25 users we will not be retrieving all of them.
We need to:
The WebAPI returns dates in UTC. We should convert to the local timezone.
The steps seem to be:
Same deal as with user retrieval, but less likely to occur.
Should describe what the current features of the connector are, and include screenshots.
They obviously do not belong in there, should in the the ReviewboardRepositoryConnector
The top and bottom comment entries from reviews should be displayed as comment text.
We should map the people and the groups set for review.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.