ronplanken / game-datacards Goto Github PK

Version Number

2.0.3

Steps to reproduce

When sharing a category of 10th edition cards, they overlap with their art making it impossible to read the cards.

https://game-datacards.eu/shared/jZOeTI7JIYh6QRAP4sJv

Expected behaviour

For 10th edition cards the width should be auto-fixed and not be fixed at 33%.

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your feature request related to a problem? Please describe.
The current printing feature always prints the background colours. Normaitje browser will remove the colours except if the users toggles the option "print backgrounds".

This was handles using a CSS property to force the colours to always be printed.

A new option should allow the user to toggle between these states.

Version Number

2.0.3

Steps to reproduce

1. Go to a random 10th edition datacard
2. Click on "Extended abilities"
3. Add a new empty ability. Do not enter a description and press the toggle for "show description".
4. See error

Expected behaviour

You should be able to enable a description even if its empty.

What browsers are you seeing the problem on?

Chrome

Relevant log output

TypeError: Cannot read properties of undefined (reading 'match')

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your feature request related to a problem? Please describe.
I want to be able to create Generic Battle Rule Cards, so that I can create and print Warhammer40k:

• MissionRules
• PrimaryMissions
• Gambits
• SecondaryMissions

Possibly could be used for Detachment Special Rules going forward

Describe the solution you'd like
I'd like a top level card that shares the same themes as the 40k ones. All the 40k cards share similar arrangement and iconography.

Mission rules have

• type name (Mission Rule)
• Title
• flavor text
• description

Primary Missions have

• type name (Primary Mission)
• Title
• flavor text
• possible base description
• phase modifiers that take effect during different turns (with specific styling)
  • Callout text for the section
  • Detail text

Secondary Missions have

• type name (Secondary Mission) - Attacker/Defender
• Title
• flavor text
• description

Gambits have

• type name (Gambit) - Attacker/Defender
• Title
• flavor text
• phased descriptions (with specific styling)
  • Callout text for the section
  • Detail text

The common design I can see is

• type name <possible Attacker/Defender designator>
• Title
• flavor text
• flexible Description Section that allows multiple child description elements with
  • raw markdown text
  • Callout text + detail text (with 2 different styles for gambit and primary mission styles)

Describe alternatives you've considered
I don't think there's another good way to do it.

Additional context

Is your feature request related to a problem? Please describe.
If i have a category filled with cards that have a points value, it is not possible to get a summary of the points in the list I created.

Describe the solution you'd like
Add a summary to the category that shows the user the total amount of points the list has.

Split off from: #62

Is your feature request related to a problem? Please describe.
When a card overflows the middle a panel a scroll bar should be available.

Is your feature request related to a problem? Please describe.

When printing the cards, I would be able to fit more cards on one page, if the empty space is removed.

Describe the solution you'd like

Add option to compress cards vertically (remove empty space)

Describe alternatives you've considered

Print more pages? :D

Additional context
Add any other context or screenshots about the feature request here.

P.S.: Loving this web-app, thanks a lot for making it!

Is your feature request related to a problem? Please describe.
Check to see if it's possible to add a "long press to right click" to menu's and other options.

Suggestion from discord:

something like use-long-press should do `the trick - you should be able to test the functionality on a phone

Version Number

2.2.0

Steps to reproduce

1. Go to https://game-datacards.eu/shared/sqwzbzW3xWJIlnpJV6Vh
2. See error:

Expected behaviour

The cards should open in the sharing window and be properly displayed.

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Version Number

2.1.0

Steps to reproduce

1. Go to https://game-datacards.eu/viewer/adeptus-custodes/blade-champion on a mobile layout
2. Observe 4+ invulerable save displaying
3. Press Share > Mobile datacard, save somewhere and open
4. Observe 4+ invulnerable save missing

Expected behaviour

Mobile datacard image export matches actual mobile datacard

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your feature request related to a problem? Please describe.

When I have the printed sheets, I don't have the mouse-over effect on abilities 🙃

Describe the solution you'd like

When I print the sheets, it would be nice to have a preamble like what battlescribe creates. This could contain an overview of all the abilities that are used by the selected datasheets (both generic and faction specific).

Describe alternatives you've considered

Writing them down by hand? 😆

Version Number

2.1.1

Steps to reproduce

1. Add any Card
2. Click on Show Back
3. Observe that it changes Print side of card in Basic Information section
4. Observe that it DOES NOT allow you to click save for the card in the upper left

Initial State:

After click Show Back:

Expected behaviour

It allows you to click save to save the card so that the front/back print side information will be propagated to the print settings in the printing workflow

What browsers are you seeing the problem on?

Firefox, Chrome, Edge

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Version Number

2.2.0

Steps to reproduce

1. Go to site
2. Choose any army
3. Search for unit datasheets
4. No datasheets found

Expected behaviour

Only stratagem cards show for any army. I've tried disabling extensions and Brave shields for the site, also clearing site data/cache/cookies, but it only ever says "No datasheets found." Works fine in Firefox on the same device.

Brave:

Firefox (expected behavior):

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your feature request related to a problem? Please describe.
I would like a smaller version of a datacard available for printing. The current mobile version of the card would be great for that.

Is your feature request related to a problem? Please describe.
An option to include a "title page", or "summary page".
It would list the Faction, the Units/points similar to a brief Battlescribe share list..
Possibly in the same format, so we can copy/paste to websites that accept that data format?

Describe the solution you'd like
This would just be an option on the print options. Most likely used when "print-to-file' to allow a copy/paste.

Describe alternatives you've considered
Using Battlescribe, but I'd rather do everything on one website/app.
Could just go to my mobile and build the list there and hit "share", but - again - would rather do it all in one place.

Additional context
This could be as easy as just the text shared when using the mobile "share" button, but it'd be nice to have
options to add more than the basics detailed in that option.

Version Number

2.1.0

Steps to reproduce

1. In Chrome or Edge, click print and configure to print 2 cards in portrait, scaled down to fit on page
2. After seeing valid images, Click print
3. Observe in the print preview that part of the lower edge of the bottom card is clipped off and put onto the next page "for no reason"

Expected behaviour

It prints correctly and exactly as seen in the datacards preview window

What browsers are you seeing the problem on?

Chrome, Edge

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your feature request related to a problem? Please describe.
Feature is related to bug #84 which caused problems understanding the intended workflow for choosing and printing sides. Could not figure out initially, and also observed that setting and saving each card individually was cumbersome.

Describe the solution you'd like
I would like to allow printing of the chosen side of a card as a setting in the print menu as opposed to on a per card basis and linking the print side to each card.

Describe alternatives you've considered
I've considered how this would interact with the current system and think it would be valuable to simply remove print_side as a property of the card itself. Currently its very inefficient for one to print the back sides of "all my cards" because you have to individually load each card, change side, then save for all individual cards. I think setting the print side is more of a property of the print workflow rather than an innate property of the card.

Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
If you are on a smaller resolution the side panels should be able to be (almost) completely hidden.