ropengov / fmi2 Goto Github PK

obs_weather_X functions take mostly the same arguments, which are passed on to the WFS. Make share helper functions that check the validity of arguments.

Hi!

First of all I would like to say thank you for providing an excellent alternative of fetching Finnish Meteorological Data through your fmi2 R package.

I have noticed some discrepancies when I compare the data I can manually download from https://en.ilmatieteenlaitos.fi/ using their graphical user-friendly web API (i.e choosing a station and parameter to produce a .csv file).

For example, one can compare Hammarlands Märkets (id: 100919) 2018-01-01 00:00. We see that the values for WD_PT1H_AVG = 141, and WS_PT1H_AVG = 11.4. However, using https://en.ilmatieteenlaitos.fi/download-observations for the parameters "wind speed" and "wind direction", the values for that same time is Wind direction (deg) = 145, Wind speed (m/s) = 10.7.

Do you know what the reason is behind such discrepancies?

Regards,
Magnus Tronstad

When trying to install this package there was not that instructive error message:
(OS: Ubuntu 20.04 LTS)

Installing package into ‘/home/nicks/R/x86_64-pc-linux-gnu-library/4.1’
(as ‘lib’ is unspecified)
ERROR: dependency ‘sf’ is not available for package ‘fmi2’

• removing ‘/home/user/R/x86_64-pc-linux-gnu-library/4.1/fmi2’
  Warning messages:
  1: In i.p(...) : installation of package ‘units’ had non-zero exit status
  2: In i.p(...) : installation of package ‘sf’ had non-zero exit status
  3: In i.p(...) :
  installation of package ‘/tmp/RtmpaXeob3/file16c6226e9d75/fmi2_0.2.0.tar.gz’ had non-zero exit status

It is recommended (rOpenSci?) that each function is in its own file, and the file name matches with the function name. I propose to make this change.

The use of FMI's open data no longer requires registration.

Registered users should switch over to the new addresses by the end of 2019 in order to use the service. Addresses that include the API key of the Finnish Meteorological Institute will no longer be operational after 2019.

The new addresses are:


https://opendata.fmi.fi/wfs (Download service - WFS)

https://openwms.fmi.fi/geoserver/wms (View service - WMS)

CRAN checks give:

Found the following (possibly) invalid URLs:
URL: http://opendata.fmi.fi/wfs?service=WFS&version=2.0.0
From: man/fmi_api.Rd
Status: 400
Message: Bad Request

The use of FMI's open data no longer requires registration.

Registered users should switch over to the new addresses by the end of 2019 in order to use the service. Addresses that include the API key of the Finnish Meteorological Institute will no longer be operational after 2019.

The new addresses are:


https://opendata.fmi.fi/wfs (Download service - WFS)

https://openwms.fmi.fi/geoserver/wms (View service - WMS)

For some reason, test local version is up-to-date with fmi_stations() fails on Appveyor while it passes locally and on TravisCI.

FMI has updated their webpages and currently fmi_stations() is unable to scrape the stations list. Fix scraping or find another way of getting the stations list.

We could collect all importFrom material from the individual R/*.R files into R/firstlib.R (as in e.g. eurostat). This helps to manage all imports in a single place.

Stored query: fmi::observations::weather::monthly::simple.

mapedit can be used to actively select sf-obejcts.