The aluejakokartat data itself seems to be ok, as it has not been updated since 2011. But the code used to read it used gisfin, which is deprecated now.

One alternative is Pyry's https://github.com/pitkant/cityhoods/blob/main/R/get_areas.R. It could be used instead of gisfin (and the takomo script), and mentioned in the function documentation.

Old Travis-CI.org service will be shut down after 31th of December, requiring either action to migrate to the commercial Travis-CI.com service or migrating to a new CI altogether. An rOpenSci blogpost describes the pros of moving to GitHub Actions. The process is as follows:

1. run: usethis::use_github_action_check_standard()
2. Check if package tests contain skip_on_travis -functions and replace them with skip_on_ci
3. Add a badge to the package README: [![R build status](https://github.com/rOpenGov/PACKAGENAME/workflows/R-CMD-check/badge.svg)](https://github.com/rOpenGov/PACKAGENAME/actions)
4. Remove Travis CI badge (and Appveyor badge as well, since GHA runs tests simultaneously for Linux, macOS and Windows)

• @ouzor implemented branch protection rules for master branch on 6.12.2022
• However, the requirement of making a PR first and getting reviews caused the following error message when changes to README.md were to be committed:

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: At least 1 approving review is required by reviewers with write access.
To https://github.com/rOpenGov/helsinki
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/rOpenGov/helsinki'
No changes to commit

• Consequently I removed the branch protection rule to get the Github action working.
• There is a GitHub Community discussion going on since 10.10.2019 about this very issue.
• We can of course always ask whether having a separate action for rebuilding the README.md file is efficient use of computational resources and whether this should be done locally.
• OR we can discuss on other ways on how to protect the master branch.

(Peter Evans' answer on SO was something I tried to utilise when finding ways to fix this problem but apparently it was no panacea for this specific configuration of protected branch)

Render README workflow fails (for example on 616a25d) with the following error: "Failed to build source package 's2' "

I'll continue monitoring if this is a temporary hiccup or perhaps related to the platform on which this workflow runs: macOS-latest

Could create one function for e.g. demographic data that lists available data sets and let's the user download them, but does minimal preprocessing.

The ones in gisfin are relatively old (2012 I think), update to newer ones (e.g. up to 2016).

Keywords are currently uninformative, either remove or improve

HSY open data pages have been updated, need to update get_hsy() correspondingly!

From Prof. Ripley:
"Those parts of examples enclosed in \donttest{} are run by examples() and so must be valid R code. This is now checked by R-devel, and the CRAN results pages for your packages show WARNINGs because some of your code is invalid.

Please submit a corrected update checked with current R-devel (note that the check stops at the first error: there may be more) as soon as possible.

There may be other issues showing on the check pages which should also be addressed."

There are now at least the following two WFS APIs available:

• https://kartta.hsy.fi/geoserver/wfs
• https://kartta.hel.fi/ws/geoserver/avoindata/wfs

Adding support for these would make sense in general, and this would also replace some of the earlier functionality that has become broken as the open data offerings have changed.

@pitkant What would be needed to support these?

Function get_servicemap() is broken, as it seems to point to a very old REST API version. A newer version is mentioned here: https://hri.fi/data/dataset//paakaupunkiseudun-palvelukartan-rest-rajapinta. That page also mentioned the WFS API, so it could be that we would not need additional Servicemap REST API support, if we would implement the WFS API.

Let's discuss first the WFS part in #17, and then decide what to do with the servicemap.

Might be good for outreach?

Current vignette is rather heavy and has produced several errors on CRAN.
@pitkant suggested simplifying the package vignette, and publishing the longer version as a blog post / article. I think this makes sense.

This does not work: url.exists("http://api.hel.fi/linkedevents/v0.1/search/")

CRAN Checks fail, see more here: https://cran.r-project.org/web/checks/check_results_helsinki.html.

Should be fixed by 30.9.

Ripley emailed:

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_helsinki.html.

Please correct before 2022-12-04 to safely retain your package on CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message
if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

Listin school results does not work in
http://louhos.github.io/news/2014/06/11/helsinki-kirjasto/

https://github.com/hadley/testthat

Note that gisfin has to be in CRAN first.
Implement a wrapper for gisfin::get_helsinki_spatial(), imports gisfin.
Additionally think about moving get_hsy() to gisfin and implementing a wrapper, as it is spatial data as well.