ropensci / barulho Goto Github PK

playback_est.R and playback_est-data.R, I think the former could be removed, since the latter shows up in the data documentation.

see progress in excess_attenuation()

Line 641: object 'W' not found

Line 642: object 'xa' not found

3 progress bar but message says there are only 2

allow users to run functions on data frames and (non-extended) selection tables

tail_to_signal_ratio and signal_to_noise_ratio measure start and end markers (and they shouldn't)

replace sim_songs from warbleR when synthetizing sounds in the vignette with synth_sounds

message to remind user to include master sound files with re-recorded sound files for search_template()

atmospheric_attenuation is documented as requiring an extended selection table (EST) but then doesn't actually take one as input. If the function doesn't need an EST, then the function description and example code should be updated. If it does need an EST, then the function arguments should be updated (but the function code doesn't seem to require an EST...).

Spectrum_correlation and spectral_correlation, both are documented as separate functions but seem identical in documentation and purpose. Is this a case of alternative names?

On https://ropensci.r-universe.dev/builds#builds we see for instance

Error: 'try_na' is not an exported object from 'namespace:warbleR'

Quitting from lines 416-421 [unnamed-chunk-12] (align_test_sounds.Rmd)
Error: processing vignette 'align_test_sounds.Rmd' failed with diagnostics:
'try_na' is not an exported object from 'namespace:warbleR'

Since you maintain both packages you know more than me about the context and might even already be aware of that. 😸

now is included in attenuation()

replace it with the analogous ohun function

error mesage if distance is not numeric for functions that compare with the shortest distance