Giter VIP home page Giter VIP logo

Comments (4)

neurolabusc avatar neurolabusc commented on May 27, 2024

This looks really useful. I have added you as a collaborator. Can I suggest you fold this into the main version? While the BSD allows you to create a branch, I think this would be a real asset. Thanks!

from dcm2niix.

benjaminirving avatar benjaminirving commented on May 27, 2024

Sure. That's sounds great.

When I get a chance, I'll create a new branch on this project and can merge once we're happy.

A few things:

  • It does require an extra library dependency: yaml-cpp
  • I'm currently requiring c++11
  • Would you prefer it all to be run from dcm2niix or should there be a second binary for batch processing e.g. dcm2niix-batch?
  • Any other suggestions or preferences?

from dcm2niix.

neurolabusc avatar neurolabusc commented on May 27, 2024

This seems fine. I would suggest we do this with a compiler switch, that allows the user to determine whether they want to enable this feature. Note I already do this to allow the user to select the gz compression (miniz vs zlib) and JPEG2000 (none, OpenJPEG, Jasper):
https://github.com/neurolabusc/dcm2niix
I do think we want to make sure our code supports both GCC and Clang/LLVM, and I also recognize that many scientists like to run older operating systems (CentOS 6.6 seems popular with FSL crowd [gcc 4.4.7], and it seems some scientists still use OSX 10.6).

"From there you can see that C++11 is supported since gcc 4.7 and gcc 4.4 has C++0x support."
http://stackoverflow.com/questions/23523634/compiling-c11-on-g-4-4-7-in-red-hat-linux

So my sense is by using a compiler directive we could support these users.

from dcm2niix.

benjaminirving avatar benjaminirving commented on May 27, 2024

I've added a branch called batch_processing to the project and updated the README in that branch to explain the new options.

Basically, it looked like it was going to be very messy to merge into a single binary so I've created the options to build a second dcm2niibatch binary that does batch conversion from the configuration file.

This requires extra packages and c++11 but is built optionally from cmake by running

cmake -DBATCH_VERSION=ON

See the updated read me file in the branch.

Let me know if you're happy with this setup. I might also look into included your qt gui as a build option in the cmake file.

from dcm2niix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.