Giter VIP home page Giter VIP logo

Comments (8)

neurolabusc avatar neurolabusc commented on May 27, 2024

@benjaminirving supports the YAML-based dcm2niibatch, and I do not have OSX Sierra. However, I assume you can still build the generic (non-batching) dcm2niix by using the "make" command which will run
g++ -dead_strip -O3 -I. main_console.cpp nii_dicom.cpp jpg_0XC3.cpp ujpeg.cpp nifti1_io_core.cpp nii_ortho.cpp nii_dicom_batch.cpp -o dcm2niix -DmyDisableOpenJPEG -DmyDisableJasper

from dcm2niix.

dangom avatar dangom commented on May 27, 2024

Yes, building dcm2niix works just fine.
The problem only affects linking dcm2niibatch against yaml-cpp.

from dcm2niix.

benjaminirving avatar benjaminirving commented on May 27, 2024

@neurolabusc, the generic dcm2niix should also still run using cmake build.

@dangom, thanks for the report. that's strange. I have been holding off upgrading to macOS Sierra for the meanwhile. The upgrade to Sierra might have broken your homebrew links. Have you tried uninstalling and reinstalling yaml-cpp after upgrade? Otherwise, I'll take the plunge and upgrade to Sierra.

from dcm2niix.

dangom avatar dangom commented on May 27, 2024

I've tried reinstalling both yaml-cpp and libyaml, and rolling back to an earlier version of cmake. The problem persisted.
I also don't think this has anything to do with homebrew. All paths look correct when I check the cmake generated files.

Unfortunately I can't go back and check the links.txtgenerated on El Capitan, because I don't have it anymore. Do you see if the flag -L/usr/local/lib is set?

If that is the case, then perhaps it's easier to add something to the CMakeLists.txt to always add this extra flag, rather than risking the update?

from dcm2niix.

benjaminirving avatar benjaminirving commented on May 27, 2024

-L/usr/local/lib is not set in links.txt on El Capital. Only -lyaml-cpp is set.

It sounds like for some reason /usr/local/lib has been dropped from the default compiler search path in macOS Sierra.

Could you run clang -Xlinker -v in bash. I get

Library search paths:
/usr/lib
/usr/local/lib

I agree with you and I'll add it as an extra flag on the CMakeLists.txt to be safe.

from dcm2niix.

benjaminirving avatar benjaminirving commented on May 27, 2024

Could you see if this branch fixes your issue?

https://github.com/rordenlab/dcm2niix/tree/sierra_yaml_fix

Thanks,
Ben

from dcm2niix.

dangom avatar dangom commented on May 27, 2024

Hi Ben,

the branch fixes the issue.
Running clang -Xlinker -v gives me the following lib search paths:

Library search paths:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/lib

And here is the version info:

$ clang -v
Apple LLVM version 8.0.0 (clang-800.0.38)
Target: x86_64-apple-darwin16.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Either a feature of the Sierra upgrade or an issue with my computer.

In any case, thanks for the quick answers.

Cheers,
Daniel

from dcm2niix.

benjaminirving avatar benjaminirving commented on May 27, 2024

Thanks Daniel.

from dcm2niix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.