Comments (4)
Pinging @DLu, @JafarAbdi, @sea-bass @rhaschke as I see your guys' names in the referenced pages.
from moveit2_tutorials.
Potential hint was found at #59 (comment), but not enough.
from moveit2_tutorials.
I repeat my objection from #61 (comment) for clarity:
The tutorials should not depend on
moveit_resources_panda_moveit_config
(which is a minimal version ofpanda_moveit_config
referring to a minimal version of the URDF model as well), but use the officialpanda_moveit_config
package instead, which uses the official URDF fromfranka_description
.
from moveit2_tutorials.
@rhaschke Please review the following and see if you can agree.
Discussed in moveit maintainers' mtg. I heard @henningkayser or someone from maintainers will comment here, but my understanding was to stick to moveit_resources
based on the following:
moveit2_tutorials
should refer tomoveit_resources
as the first place to look up robot resource.- panda_moveit_config is a "vendor package", so changes that
moveit2_tutorials
need can't always be made there.- In hindsight, I'm not sure what that means, particularly when the repo is under
ros-planning
org. Is the repo maintained by vendor and there's no non-vendor maintainers on that repo?
- In hindsight, I'm not sure what that means, particularly when the repo is under
- moveit2 tutorials is migrating to kinova.
It's in the mtg minutes as well, citing here:
[Isaac] Robert says the tutorials shouldn’t depend on the moveit_resources versions
[Henning] He isn’t wrong. We have been using moveit_resources because we can easily update it and Franka is not actively maintaining their configs. We shouldn’t make moveit_resources depend on the franka repo. We are also transitioning to kinova arm in tutorials.
[Alex] Because Robert objected to Kinova configs being merged into moveit_resources we put in its own repo. It would be easier if all our configs were in one place but it does make sense that each robot should be in its own place.
[Tyler] You are welcome to use Kinova for your tutorial if that is easier.
[Isaac] Are you accepting PRs for non-Kinova arms?
[Tyler] Yes, we are happy to accept PRs with either. Thank you for working on this.
My personal comment as a community user: Obvious caveat is maintaining almost duplicate (if there's an upstream exists like the case with panda), but I assume communication overhead with vendors often kills the benefit of using upstream?
from moveit2_tutorials.
Related Issues (20)
- realtime_servo can not control by keyboard input. fixed in local test HOT 1
- C++ API -> "Pick and Place" tutorial is not ROS2-ified HOT 1
- MTC demo.launch.py fails: "Could not find parameter robot_description_semantic and did not receive robot_description_semantic" HOT 2
- build failed. "moveit_core::moveit_butterworth_parameters" but the target was not found. HOT 2
- Moveit Python available for Ros2 Humble? HOT 2
- Unable to build "moveit_task_constructor_capabilities" package. HOT 4
- Incorrect Place Poses Generated in MTC Tutorial HOT 3
- Python API tutorial launch file not working with default parameters HOT 11
- Warning due to deprecated functions HOT 1
- Python API documentation missing? HOT 2
- Humble branch breaks Python API and default version HOT 2
- MoveIt2 and Omniverse Isaac Sim connection is not working (demo_isaac) HOT 2
- Error while launching demo tutorial HOT 15
- can not make the panda move when i click 'plan & execute' HOT 3
- CI is failing with segfault on teardown of test HOT 5
- Docker build failing in CI due to missing file
- Humble Docker images need to build Humble branch of MTC HOT 1
- colcon build --mixin release Failure with moveit 2 HOT 6
- Moveit2_turorials Panda robot is faulting when loading Chomp.
- topic_based_ros2_control is seg faulting when calling write() on the Panda robot tutorial.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moveit2_tutorials.