Comments (8)
Interesting, thanks for bringing this up @nnmm.
It seems like this is handled fine on Ubuntu:
++ colcon list --paths-only --packages-up-to examples_rclrs_message_demo examples_rclrs_minimal_client_service examples_rclrs_minimal_pub_sub rclrs rclrs_example_msgs rosidl_generator_rs rosidl_runtime_rs
+ package_paths='src/mo0f04hva3p/ros2_rust/examples/message_demo
src/mo0f04hva3p/ros2_rust/examples/minimal_client_service
src/mo0f04hva3p/ros2_rust/examples/minimal_pub_sub
src/mo0f04hva3p/ros2_rust/rclrs
src/mo0f04hva3p/ros2_rust/rclrs_example_msgs
src/mo0f04hva3p/ros2_rust/rosidl_generator_rs
src/mo0f04hva3p/ros2_rust/rosidl_runtime_rs
src/ros2/common_interfaces/std_msgs
src/ros2/example_interfaces
src/ros2/rcl_interfaces/action_msgs
src/ros2/rcl_interfaces/builtin_interfaces
src/ros2/rosidl_defaults/rosidl_default_generators
src/ros2/rosidl_defaults/rosidl_default_runtime
src/ros2/unique_identifier_msgs'
+ rosdep install -r --from-paths src/mo0f04hva3p/ros2_rust/examples/message_demo src/mo0f04hva3p/ros2_rust/examples/minimal_client_service src/mo0f04hva3p/ros2_rust/examples/minimal_pub_sub src/mo0f04hva3p/ros2_rust/rclrs src/mo0f04hva3p/ros2_rust/rclrs_example_msgs src/mo0f04hva3p/ros2_rust/rosidl_generator_rs src/mo0f04hva3p/ros2_rust/rosidl_runtime_rs src/ros2/common_interfaces/std_msgs src/ros2/example_interfaces src/ros2/rcl_interfaces/action_msgs src/ros2/rcl_interfaces/builtin_interfaces src/ros2/rosidl_defaults/rosidl_default_generators src/ros2/rosidl_defaults/rosidl_default_runtime src/ros2/unique_identifier_msgs --ignore-src --skip-keys 'rti-connext-dds-5.3.1 ' --rosdistro rolling -y
(from: https://github.com/ros2-rust/ros2_rust/runs/7839025061?check_suite_focus=true#step:10:135)
but not on Windows:
++ colcon list --paths-only --packages-up-to examples_rclrs_message_demo
+ package_paths='src\r3ydc6px8z\ros2_rust\examples\message_demo
src\r3ydc6px8z\ros2_rust\rclrs
src\r3ydc6px8z\ros2_rust\rclrs_example_msgs
src\r3ydc6px8z\ros2_rust\rosidl_generator_rs
src\r3ydc6px8z\ros2_rust\rosidl_runtime_rs
src\ros2\rosidl_defaults\rosidl_default_generators
src\ros2\rosidl_defaults\rosidl_default_runtime'
+ rosdep install -r --from-paths 'src\r3ydc6px8z\ros2_rust\examples\message_demo
' 'src\r3ydc6px8z\ros2_rust\rclrs
' 'src\r3ydc6px8z\ros2_rust\rclrs_example_msgs
' 'src\r3ydc6px8z\ros2_rust\rosidl_generator_rs
' 'src\r3ydc6px8z\ros2_rust\rosidl_runtime_rs
' 'src\ros2\rosidl_defaults\rosidl_default_generators
' 'src\ros2\rosidl_defaults\rosidl_default_runtime' --ignore-src --skip-keys 'rti-connext-dds-5.3.1 ' --rosdistro foxy -y
given path 'src\r3ydc6px8z\ros2_rust\examples\message_demo
' does not exist
(from: https://github.com/ros2-rust/ros2_rust/runs/7827723402?check_suite_focus=true#step:11:115)
I think a simple pipe through tr '\n' ' '
after colcon list ...
might fix this. Hopefully it works on Windows. I'll try to do this soon.
from action-ros-ci.
@nnmm could you try #767? e.g. ros-tooling/action-ros-ci@fix-rosdep-install-trailing-newline-windows
from action-ros-ci.
@nnmm note that I think rosdep
doesn't work on Windows, though:
from action-ros-ci.
@christophebedard Thanks. It looks the same with that branch unfortunately: https://github.com/ros2-rust/ros2_rust/runs/7898904995?check_suite_focus=true
If rosdep doesn't work, is there some way to tell action-ros-ci
to skip that step? action-ros-ci
is supposed to work with Windows, right?
from action-ros-ci.
@nnmm ahh I quickly looked at CI for my PR and thought my fixed worked, but it didn't. I'll try to do a proper fix.
If rosdep doesn't work, is there some way to tell
action-ros-ci
to skip that step?
We can always add an option to skip rosdep
, but it shouldn't make the CI job fail since we're using a trailing || true
:
action-ros-ci/src/action-ros-ci.ts
Line 186 in e0eeca0
colcon build
step, although I'm not quite sure why it fails.
action-ros-ci is supposed to work with Windows, right?
Not fully, unfortunately, see #725. Windows support has always been partial and finicky.
from action-ros-ci.
@christophebedard Have you had a chance to look for a proper fix yet? :)
from action-ros-ci.
@nnmm I have not, but since rosdep
basically doesn't do anything on Windows currently, that step should just be skipped. I'll try to do that tomorrow.
from action-ros-ci.
from action-ros-ci.
Related Issues (20)
- Option for Catkin Build for ROS 1 Projects HOT 1
- Split build and test steps
- Support other ways of selecting packages HOT 2
- Failed to build fork private repo (PR) HOT 9
- Args set using colcon-defaults do not reflect in workflow run HOT 9
- Can't load rclcpp::components in containers during test HOT 5
- Test failure on Galactic HOT 4
- ModuleNotFoundError: No module named 'catkin_pkg' when building ROS2 package using [email protected] HOT 2
- Skip `rosdep install` HOT 8
- wrong URL for GitHub Enterprise repos HOT 3
- [README Docs Request] A remark on setup-ros vs Docker already setup HOT 2
- Cannot get local files with vcs-repo-file-url HOT 3
- Have the default examples have the steps to install other DDS implementations
- Build Error on ROS Noetic HOT 5
- Source local setup after the build completes HOT 4
- Rolling CI fails HOT 8
- Remove support for macOS HOT 1
- Allow to choose the option "--symlink-install"
- Action ignores failed rosdep install HOT 2
- missing pip since 0.3.8 HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-ros-ci.