Giter VIP home page Giter VIP logo

Comments (4)

piraka9011 avatar piraka9011 commented on August 19, 2024

This is a reasonable enhancement.
Some questions:

  • Can this file also be hosted in a gist or should this be local to the repo it's running in only?
  • Would it be better to add this feature to setup-ros-docker and improve that as well?

from action-ros-ci.

seanyen avatar seanyen commented on August 19, 2024
  • Can this file also be hosted in a gist or should this be local to the repo it's running in only?

I don't think colcon can take a URL here: https://github.com/colcon/colcon-defaults/blob/78f808ef9705a15a52d00b0adfee342d1390b348/colcon_defaults/argument_parser/defaults.py#L72

But I think developers can add another step before using this action to copy their gist?

  • Would it be better to add this feature to setup-ros-docker and improve that as well?

Interesting. Can you elaborate more on what's the improvement you envision?

from action-ros-ci.

piraka9011 avatar piraka9011 commented on August 19, 2024

I don't think colcon can take a URL here: https://github.com/colcon/colcon-defaults/blob/78f808ef9705a15a52d00b0adfee342d1390b348/colcon_defaults/argument_parser/defaults.py#L72

What I meant is doing something similar to action-ros-ci where we allow users to pass a file or a URL (see this for example).

Interesting. Can you elaborate more on what's the improvement you envision?

Thought you might have some insight as to whether there would have to be a docker specific implementation if we want to add this feature to a docker action.

from action-ros-ci.

seanyen avatar seanyen commented on August 19, 2024

What I meant is doing something similar to action-ros-ci where we allow users to pass a file or a URL (see this for example).

Ah sure. That's something doable.

from action-ros-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.