Comments (4)
This is a reasonable enhancement.
Some questions:
- Can this file also be hosted in a gist or should this be local to the repo it's running in only?
- Would it be better to add this feature to
setup-ros-docker
and improve that as well?
from action-ros-ci.
- Can this file also be hosted in a gist or should this be local to the repo it's running in only?
I don't think colcon
can take a URL here: https://github.com/colcon/colcon-defaults/blob/78f808ef9705a15a52d00b0adfee342d1390b348/colcon_defaults/argument_parser/defaults.py#L72
But I think developers can add another step before using this action to copy their gist
?
- Would it be better to add this feature to
setup-ros-docker
and improve that as well?
Interesting. Can you elaborate more on what's the improvement you envision?
from action-ros-ci.
I don't think
colcon
can take a URL here: https://github.com/colcon/colcon-defaults/blob/78f808ef9705a15a52d00b0adfee342d1390b348/colcon_defaults/argument_parser/defaults.py#L72
What I meant is doing something similar to action-ros-ci where we allow users to pass a file or a URL (see this for example).
Interesting. Can you elaborate more on what's the improvement you envision?
Thought you might have some insight as to whether there would have to be a docker specific implementation if we want to add this feature to a docker action.
from action-ros-ci.
What I meant is doing something similar to action-ros-ci where we allow users to pass a file or a URL (see this for example).
Ah sure. That's something doable.
from action-ros-ci.
Related Issues (20)
- Option for Catkin Build for ROS 1 Projects HOT 1
- Split build and test steps
- Support other ways of selecting packages HOT 2
- Failed to build fork private repo (PR) HOT 9
- Args set using colcon-defaults do not reflect in workflow run HOT 9
- Can't load rclcpp::components in containers during test HOT 5
- Test failure on Galactic HOT 4
- ModuleNotFoundError: No module named 'catkin_pkg' when building ROS2 package using [email protected] HOT 2
- Skip `rosdep install` HOT 8
- wrong URL for GitHub Enterprise repos HOT 3
- [README Docs Request] A remark on setup-ros vs Docker already setup HOT 2
- Cannot get local files with vcs-repo-file-url HOT 3
- Have the default examples have the steps to install other DDS implementations
- Build Error on ROS Noetic HOT 5
- Source local setup after the build completes HOT 4
- Rolling CI fails HOT 8
- Remove support for macOS HOT 1
- Allow to choose the option "--symlink-install"
- Action ignores failed rosdep install HOT 4
- missing pip since 0.3.8 HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-ros-ci.