Comments (2)
Ah. So there is indeed some confusion here.
The most canonical thing to look at is the sources. There are a few different places where we define and use this:
- https://github.com/ros2/demos/blob/6ac07b927a99e7e5372eb1574b31e0f95c4f78d5/action_tutorials/action_tutorials_interfaces/action/Fibonacci.action indeed calls it "partial_sequence". This is the action most visible to users.
- https://github.com/ros2/test_interface_files/blob/c5941d36e977b75c8949c9d30883248246a84693/action/Fibonacci.action calls it "sequence". I think this file is really only used for tests, but I'm not sure.
- https://github.com/ros2/example_interfaces/blob/4d7d086e4791e1839fecb9c50a1291d4056b916f/action/Fibonacci.action also calls it "sequence". This one is used in some of our other example code.
Really what we should do is to fix the confusion in the sources first, and just have a single "Fibonacci.action" file. Once that is done, we can then update the documentation to reflect what we chose.
from ros2_documentation.
Hi @clalancette
waht do you think about keeping the example_interface/action/fibonacci
and remove the other two inside test_interfaces_files
and action_tutorials_interfaces
?
This may require changes in the following packages:
- rcl_interfaces
- example_interfaces (use partial_sequence)
- test_interface_files (remove Fibonacci.action)
- rosidl_generator_tests
- rcl_action
- Remove
action_tutorials_interfaces
- action_tutorials/action_tutorials_py and action_tutorials/action_tutorials_cpp
- rclcpp_action
- system_tests
from ros2_documentation.
Related Issues (20)
- colcon build not working HOT 2
- ROS 2 Translation to Korean HOT 2
- Lose plugin.xml in rqt HOT 2
- colcon build ERROR: colcon.colcon_core.package though build completes HOT 1
- Nomenclature of tf_echo and tf_listener HOT 3
- Lost documentation from the previous version of ROS2 for installing on debian HOT 1
- add user tutorial and release note for `ros2 bag service echo/play` HOT 1
- Doc: numbering is off on page "Using variants" HOT 3
- humble: `ros2 action type` - invalid choice: 'type' HOT 1
- humble: replace heading `7 ros2 action interface show` with `7 ros2 interface show` HOT 1
- confusion: does `colcon` or `rosdep` install packages from `package.xml`? HOT 3
- Workshopping a ROS / Gazebo Tutorial Page to Land Under "Related Projects" HOT 14
- Rviz2 can't start. HOT 1
- [Question] ROS1 bridge tutorial proposed for Jazzy
- Restore Python tf2 Time tutorials
- DOC
- Proposal for reshaping Launch tutorials HOT 4
- WARNING: 'any' reference target not found: latest_release HOT 1
- pip install fails with `error: externally-managed-environment` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ros2_documentation.