rosariobrancato / majesty Goto Github PK

To counter the "long" lasting loading of the login MVC, we should add a splash screen.

Bootstrap CSS changes the text color of warning alerts to white, while having the background also white.

Since the user can change server/port parameters in the login screen, I would like to check wether the connection with the server has succeeded or not before sending a request.
Is there a method for this or could you recommend something?

I will add a credits section somewhere (probably as an icon on the login screen). The goal is to show which open source stuff is being used in the game.
Please add every library or material you added to Majesty, which was found on the internet as a comment here, including source and name of author. Lines of code found on Stackoverflow or so have to be documented in the javadoc comments.

• jboot Bootstrap CSS Theme, https://github.com/dicolar/jbootx
• Background image, Derek Story, https://unsplash.com/photos/DfB43Xt13d0
• Commons Validator, Apache Commons, https://commons.apache.org/proper/commons-validator

Hey Lee

Two enhancement suggestions for you:

1.) Would be awesome if hitting enter would send the message :)
2.) If system sends the message, the sender should be shown as system instead of nothing

Thanks a lot and cheers,

Dario

In the LobbyRequestHandler the RequestId GET_USER_OF_CLIENT is handled.

In my opinion such a request should be handled by the AuthRequestHandler since on the server side, the request is not bound to a lobby.

Don't forget to change the int value of the ID.

PlayScreen and Lobby can be confused because of potentially outdated LobbyDTO's being distributed to clients. Example to reproduce (not a bad error, but would be nice if this would never happen):

1.) Open two clients
2.) Create a lobby and join the other client to the lobby
3.) Open a third client - login but don't join the lobby
4.) Now leave the lobby with one of the clients - do not refresh with the third client
5.) Join the existing lobby with the third client

Step 5 will result in distributing an "old" LobbyDTO where the lobby still consisted of both the two player that initially joined...

I tried to handle it by forcing the model to refresh the LobbyDTO List, however I do not manage. Any idea, support?

Cheers

I get a strange exception whenever I close a window (either dialog or not):

Dec 04, 2018 11:16:52 PM javafx.fxml.FXMLLoader$ValueElement processValue WARNING: Loading FXML document with JavaFX API of version 10.0.1 by JavaFX runtime of version 8.0.191 Controllers: 1 Dec 04, 2018 11:16:55 PM javafx.fxml.FXMLLoader$ValueElement processValue WARNING: Loading FXML document with JavaFX API of version 10.0.1 by JavaFX runtime of version 8.0.191 Initializing RegContr Controllers: 2 Exception in thread "JavaFX Application Thread" java.lang.RuntimeException: java.lang.reflect.InvocationTargetException at javafx.fxml.FXMLLoader$MethodHandler.invoke(FXMLLoader.java:1774) at javafx.fxml.FXMLLoader$ControllerMethodEventHandler.handle(FXMLLoader.java:1657) at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191) at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74) at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49) at javafx.event.Event.fireEvent(Event.java:198) at javafx.scene.Node.fireEvent(Node.java:8411) at javafx.scene.control.Button.fire(Button.java:185) at com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(ButtonBehavior.java:182) at com.sun.javafx.scene.control.skin.BehaviorSkinBase$1.handle(BehaviorSkinBase.java:96) at com.sun.javafx.scene.control.skin.BehaviorSkinBase$1.handle(BehaviorSkinBase.java:89) at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:218) at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191) at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74) at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54) at javafx.event.Event.fireEvent(Event.java:198) at javafx.scene.Scene$MouseHandler.process(Scene.java:3757) at javafx.scene.Scene$MouseHandler.access$1500(Scene.java:3485) at javafx.scene.Scene.impl_processMouseEvent(Scene.java:1762) at javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2494) at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:394) at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:295) at java.security.AccessController.doPrivileged(Native Method) at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$353(GlassViewEventHandler.java:432) at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:389) at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:431) at com.sun.glass.ui.View.handleMouseEvent(View.java:555) at com.sun.glass.ui.View.notifyMouse(View.java:937) at com.sun.glass.ui.win.WinApplication._runLoop(Native Method) at com.sun.glass.ui.win.WinApplication.lambda$null$147(WinApplication.java:177) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at sun.reflect.misc.Trampoline.invoke(Unknown Source) at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at sun.reflect.misc.MethodUtil.invoke(Unknown Source) at javafx.fxml.FXMLLoader$MethodHandler.invoke(FXMLLoader.java:1769) ... 48 more Caused by: java.lang.NullPointerException at com.sun.javafx.binding.ExpressionHelper.removeListener(ExpressionHelper.java:74) at javafx.beans.property.ObjectPropertyBase.removeListener(ObjectPropertyBase.java:92) at ch.fhnw.projectbois._mvc.Controller.destroy(Controller.java:107) at ch.fhnw.projectbois.registration.RegistrationController.destroy(RegistrationController.java:53) at ch.fhnw.projectbois._application.MetaContainer.destroyController(MetaContainer.java:59) at ch.fhnw.projectbois._mvc.Controller.initMVCAsDlg(Controller.java:96) at ch.fhnw.projectbois.login.LoginController.btn_Login_registerClicked(LoginController.java:186) ... 58 more Exception in Application stop method java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at com.sun.javafx.application.LauncherImpl.launchApplicationWithArgs(LauncherImpl.java:389) at com.sun.javafx.application.LauncherImpl.launchApplication(LauncherImpl.java:328) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at sun.launcher.LauncherHelper$FXHelper.main(Unknown Source) Caused by: java.lang.RuntimeException: Exception in Application stop method at com.sun.javafx.application.LauncherImpl.launchApplication1(LauncherImpl.java:922) at com.sun.javafx.application.LauncherImpl.lambda$launchApplication$154(LauncherImpl.java:182) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.NullPointerException at com.sun.javafx.binding.ExpressionHelper.removeListener(ExpressionHelper.java:74) at javafx.beans.property.ObjectPropertyBase.removeListener(ObjectPropertyBase.java:92) at ch.fhnw.projectbois._mvc.Controller.destroy(Controller.java:107) at ch.fhnw.projectbois.registration.RegistrationController.destroy(RegistrationController.java:53) at ch.fhnw.projectbois._application.MetaContainer.destroyControllers(MetaContainer.java:67) at ch.fhnw.projectbois._application.Main.stop(Main.java:62) at com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$162(LauncherImpl.java:882) at com.sun.javafx.application.PlatformImpl.lambda$runAndWait$174(PlatformImpl.java:326) at com.sun.javafx.application.PlatformImpl.lambda$null$172(PlatformImpl.java:295) at java.security.AccessController.doPrivileged(Native Method) at com.sun.javafx.application.PlatformImpl.lambda$runLater$173(PlatformImpl.java:294) at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95) at com.sun.glass.ui.win.WinApplication._runLoop(Native Method) at com.sun.glass.ui.win.WinApplication.lambda$null$147(WinApplication.java:177) ... 1 more Exception running application ch.fhnw.projectbois._application.Main

Any idea @Strather ?

Would be nice if not only the card itself but the whole hoverable region would be clickable :-)

One does not simply - leave network communication unencrypted

Would be a nice enhancement if we have time left :) Posting this so it's written somewhere

Does anyone have an example of how to get a string from the locale property file or how to initialize a window with those strings?