rosmaryfc / hw-20150320 Goto Github PK

Overall, very good job.

You document your code really well and have consistent formatting. I provided a more detail break down for each homework question:

Divisor Pattern Art

Great job. Very well documented and clean code.

One thing I want to point out is that you have capitalized N on L23. Generally, you capitalize your variables if it is a constant and in this case it is not since we are getting user input so it should be lower case.

Twenty Questions Game

Great job! Very well documented and clean code.

A Pretty Title

Great job, your program produces the correct output.
There is one small code formatting inconsistency on L33... In all other instances of using if-else, you have the { on the same line as else.

It is a good habit to document your code with comments but the comments should be meaningful and help explain complicated code... Some of the comments in this program are not necessary. For example, the comment at L42 is not needed since it is already clear what System.out.println() does.

Another example of a comment that is not necessary is L50. We already know functions/methods contain code that does something.

A more appropriate comment for functions/methods is to summarize what they do. So a comment like:

// The underline method prints a character (i.e.: *) under each letter. 
// Returns an underlined String pattern
public static String underline(...) {
    ...
}

Fibonacci

Great job! Very well documented and clean code.