ross / zfs-periodic Goto Github PK

I wanted to play around with zfs-periodic, but I am missing a license. I also looked at the port to no avail.

Can you please add license information?

While not explicitly documented, it is possible (and supported by core ZFS and utilities) to create ZFS datasets with spaces in them (see openzfs/zfs#1027 for a small discussion). zfs-periodic fails to support such datasets due to use of simplistic shell variable splitting using the default IFS which splits on spaces. Example from the code:

datasets=$(zfs list -r -H -o name $pool)
# ...
for dataset in $datasets; do

I've noticed this only after 4 years of using zfs-periodic that one of my ZFS filesystems wasn't snapshotting properly. 😅

Please consider supporting such datasets.

Since ZFS allows to store arbitrary attributes, maybe it would be useful to store number of snapshots to keep in variables like org.freebsd:snapshots.hourly|daily|weekly|monhtly?

I'll make a patch if someone is interested

Thanks for this.

Would you consider adding pre-hook/post-hook functionality for snapshots?
It could be used to "prepare" services for snapshot taking (e.g. to flush MariaDB tables).

I believe the offending code to be:

    if [ -n "$skip" ]; then
egrep="($(echo $skip | sed "s/ /|/g"))"
            datasets=$(zfs list -r -H -o name $pool | egrep -v "$egrep")
    else
datasets=$(zfs list -r -H -o name $pool)
    fi

If I have datasets:
tank/t
tank/tv

and I don't want snapshots on tank/t
If I list it in the excludes in periodic.conf, tank/tv no longer receives snapshots.

Supposedly no license => copyright (and I committed a crime by forking this repo?). MIT is a nice one :-D