rowino / inflection-js Goto Github PK

What steps will reproduce the problem?
1. Passing curves to singularize gets you curf.

What steps will reproduce the problem?
1. trying to singularize a word that doesn't match any singularizing rules.

What is the expected output? What do you see instead?
Javascript error: this._singular_rules[x] doesn't have any properties: in
other words, we accessed a _singular_rules item past the end of the array.

What version of the product are you using? On what operating system?
-doesn't matter-

Please provide any additional information below.
-none-

What steps will reproduce the problem?
1. 'address'.singularize()

What is the expected output? What do you see instead?
'address' is expected
'addres' is returned

What version of the product are you using? On what operating system?
the most recent

Please provide any additional information below.

I added the following line into the singular rules to solve the issue:

        [new RegExp('(address)$', 'gi'),                                                   '$1'],

1. Run .singularize() on a singular word (e.g. "word".singularize()) 

I expected to get "word" but instead inflection-js returns an object and not a 
string.

What version of the product are you using? On what operating system?
I am using the latest version (r38) on Mac OSX with Google Chrome and Firefox.

In Firefox in returns "String { 0="w", 1="o", more...}"  which is peculiar

What steps will reproduce the problem?
1. call "22".ordinalize()
2. see that it has not ordinalized the numbers in the string
3. frown.

What is the expected output? What do you see instead?
expected: "22nd"
got: "22"

What version of the product are you using? On what operating system?
latest download

What steps will reproduce the problem?
1. pluralize the word Leaf
2.
3.

What is the expected output? What do you see instead?
Expected: Leaves   Actual: Leafs

What version of the product are you using? On what operating system?
r38 on W7

Please provide any additional information below.

String.pluralize() and String.singularize() return objects rather than strings 
as "this" always points to an object, adding the toString() means we return a 
String as expected.

The correct English plurals of "octopus" and "virus" are "octopuses" and 
"viruses".

"Octopi" comes from a mistaken belief that "octopus" is a Latin word; it is 
not, it's Greek.  The Greek plural would be "octopedes", but the common plural 
in English by biologists is "octopuses".

"Virus" is Latin, but is a mass noun in Classical Latin, and thus would never 
be pluralized by a native speaker.  It's also a neuter noun of the second 
declension, and nouns in that class are so rare that there are no known 
instances of one being pluralized in Classical Latin -- thus, no one knows what 
the correct plural would have been even if "virus" could have been pluralized 
in Latin.

In Neo-Latin, "virus" has three different plural forms, depending on what case 
it's used in.  These are "vira", "virorum", and "viris".

It should be noted that biologists continue to use "virus" as a mass noun in 
English -- thus, "viruses" is only used when multiple strains are being spoken 
of.  ("We discovered several new viruses", but "That vial is full of virus".)

Looking at String.humanize() I think it could be (marginally) faster and 
(arguably) prettier like so:

if(!String.prototype.humanize)
  String.prototype.humanize=function(lowFirstLetter)
  {
    var str = this
                .toLowerCase()
                .replace(/_id|_ids/g, '')
                .replace(/_/g, ' ');
    if(!lowFirstLetter)str=str.capitalize();
    return str;
  };

Would you consider this change? If so, what is the proper channels to submit a 
pull request?

Thanks!

David

What steps will reproduce the problem?
1.'miss'.singularize();
2.'pass'.singularize();

What is the expected output? What do you see instead?
Expected outputs are 'miss' and 'pass' respectively but instead, 'mis' and 
'pas' are being returned.

What version of the product are you using? On what operating system?
r38 on Windows Vista

Testing for if(window) fails on node.js as window is undefined, using a typeof 
check instead fixes this.