Option to prevent get_git_head_revision from traversing parent directories about cmake-modules HOT 10 CLOSED

I think 43a50aa should fix this, by a slightly different (and backward compatible) method, can you double-check?

from cmake-modules.

Sorry, it's been so long I don't even remember which project I was trying to get building. So I can't test. But the patch looks fine to me.

from cmake-modules.

Thanks anyway!

from cmake-modules.

Hello!
After this commit, my code is

SET (MENGINE_ENGINE_GIT_SHA1 "0000000000000000000000000000000000000000")
get_git_head_revision (GIT_REFSPEC MENGINE_ENGINE_GIT_SHA1)

stopped working and returns me GITDIR-NOTFOUND

https://github.com/irov/Mengine/blob/master/src/Config/CMakeLists.txt

Thanks!

from cmake-modules.

Is your CMAKE_SOURCE_DIR not in the same directory as your git repo root?

from cmake-modules.

Is your CMAKE_SOURCE_DIR not in the same directory as your git repo root?

Yes, my CMakeLists.txt place in ./cmake/Win32/

from cmake-modules.

OK, yeah, we'll have to tweak something here. I'll see if I can poke together something.

from cmake-modules.

There, pushed something for you @irov , hope it helps! If you still have issues, open a new issue.

from cmake-modules.

for get_git_head_revision(GIT_REFSPEC MENGINE_ENGINE_GIT_SHA1)

CMake Error at D:/Projects/Mengine/dependencies/cmake-modules/GetGitRevisionDescription.cmake:89 (if):
  if given arguments:

    "STREQUAL" "ALLOW_LOOKING_ABOVE_CMAKE_SOURCE_DIR"

  Unknown arguments specified

but get_git_head_revision(GIT_REFSPEC MENGINE_ENGINE_GIT_SHA1 "ALLOW_LOOKING_ABOVE_CMAKE_SOURCE_DIR")

it's good! Thanks!

from cmake-modules.

oh, oops, thanks. Fixed that now.

from cmake-modules.