`get_git_head_revision` forces full project recompile on every different commit about cmake-modules HOT 9 CLOSED

I think the author explains here how to circumvent this problem: https://stackoverflow.com/a/4318642/15282333

Although I haven't been able to get it to work with my setup yet.

from cmake-modules.

I'm not sure why that's happening, but I haven't added a definition in that way before. I typically use it to generate a source file instead, which does successfully avoid a full recompile on every build.

from cmake-modules.

The stack overflow option uses a configure file command which would only be run at configuration time. This is undesirable because it would not update GitSHA1.cpp at build time like it does in my example. You would have to reconfigure your project every time you make a commit which is even worse.

from cmake-modules.

well, any of the options using this module re-configure every time, that's more or less the key feature of this module? (that it triggers a re-configure on commit) If you just want to have it at build time, I guess you could call some of the functions from an add_custom_command()

from cmake-modules.

Fair enough, however this is just a way to do the same without using template files. It should also be constrained to that one file thus not cause any other files to require rebuilding.

set_property(
  SOURCE ${CMAKE_CURRENT_LIST_DIR}/GitSHA1.cpp
  PROPERTY COMPILE_DEFINITIONS
    "GIT_SHA1=\"${GIT_SHA1}\""
)

from cmake-modules.

I'm pretty sure this is not an issue with this module, but something with how you're using CMake. I agree that doesn't look like it should cause other rebuilds (though it will require and trigger reconfig), but it's not a use pattern I'm familiar with.

I'd happily review a suggested change to fix this, if it is in fact an issue with the module.

from cmake-modules.

I'll come up with a repro case with both ways. If it is indeed my usage I'll close.

from cmake-modules.

Really looks like it's related to set_property(SOURCE ... PROPERTY COMPILE_DEFINITIONS)
It's really disappointing that cmake forces a whole recompile if a compile definition changes on a single cpp file.

from cmake-modules.

Yeah that sounds like it's probably a cmake bug, recommend reporting

from cmake-modules.