Is one of these 'x's supposed to be an 'X' ?

Salut @rs

Yarn complains that the 1.1.0 version is not available

But the changelog does mention this version: https://github.com/rs/node-netmask/blob/master/CHANGELOG.md#v110-mar-18-2021

Is there something I am missing?

Thanks for your help

Noticed this module has a explicit dependency for coffee-script 1.2.0. Does it really need this specific version? I would need to use 1.3.3. Could the dependency be changed to e.g. >=1.2.0?

Hi there,

Thanks heaps for the library. Would be awesome to add a isValid property to the netmask object. Maybe something like:

this.isValid = (this.base == '0.0.0.0') ? false : true;

If you agree, I can create a pull request.

Would it be possible to add a changelog detailing the breaking changes (if any) that were introduced in v2.0.0?

I'm sure a lot of folks are eager to upgrade to mitigate the security vulnerability present in 1.x.

0.0.0.0/0 does not match all IPs as expected. I guess there is a problem when calculating maskLong.
when mask = 0, it is expected that maskLong is 0x00000000 but it becomes 0xffffffff instead.

npm install netmask

Then adding

var metmask = require('netmask').NetMask;

Into my javascript application, gives a module not found.

If I go into the lib and compile netmask.coffee into js

 coffee -c netmask.coffee

This then makes the module work.

I've got coffee script installed globally and am running node 0.6.14

The first IP address of a block should end with .0 but first() returns an IP address of .1.

The Perl Net::Netmask, upon which this is based, says in the documentation: "->first() & ->last() Synonyms for ->base() and ->broadcast()" and base should return the base address of the network block and broadcast should return the last IP address.

The code
@FIRST = if @bitmask <= 30 then long2ip(@netlong + 1) else @base
should be moved after @base is set and changed to
@FIRST = @base

In common usage, the first address in a subnet, all binary zero in the host identifier, is reserved for referring to the network itself, while the last address, all binary one in the host identifier, is used as a broadcast address for the network; this reduces the number of addresses available for hosts by 2.

While this is true, the actual CIDR range consists of the full set of IP addresses in the range even if those two IP address shouldn't be assigned to host machines.

Hi,

I noticed 1.1.0 (with the octal fix) isn't on npm.

https://www.npmjs.com/package/netmask

Can you release it please?

Thanks.

> netm = new Netmask('192.168.1.0/255.255.255.0')
Netmask {
maskLong: 4294967040,
bitmask: 24,
netLong: 3232235776,
size: 256,
base: '192.168.1.0',
mask: '255.255.255.0',
hostmask: '0.0.0.255',
first: '192.168.1.1',
last: '192.168.1.254',
broadcast: '192.168.1.255' }
> netm.contains('192.168.1.2')
false
>

expected result : true

When constructing an instance with the form x.y I would expect one of two things:

1. An error because this is not a valid IP address.
2. The input to be parsed the same as x.y.0.0/16.

Instead, the input is parsed as x.0.0.y/32, which makes very little sense to me:

> (new netmask.Netmask('1.2')).toString()
'1.0.0.2/32'

The output is similarly odd when providing 1 or 3 octets:

> (new netmask.Netmask('1')).toString()
'0.0.0.1/32'
> (new netmask.Netmask('1.2.3')).toString()
'1.2.0.3/32'

README.md states that one of the ways a Netmask can be constructed is with the following parameters:

'216.240.32.0', 0xffffff00

The following code, however, causes an Error to be thrown:

var netmask = require("netmask");
var block = new netmask.Netmask('10.0.0.0', 0xffffff00);

The code that throws the error is here.

1. In the latest 2.0.2 there was a rewrite of the IP validation. Effectively, in version 2.0.2 the sanity check that IP components are < 0xFFFFFFFF has been removed, because >>> 0 always converts them to a 32-bit unsigned long.
   This can cause trouble, for example this "IP" actually checks out as belonging to the localhost block: "4294967423.0.0.1" (because mod 2^32 it is equal to 127.0.0.1).
   Although it's obviously an invalid IP, this has the potential to create shenanigans, because other libraries probably are not making the exact same mistake.

2. Another input validation issue is the use of the ParseInt function for the mask parameter. For example two possible inputs that generate a nonsensical state:
   (a) Try weird = new Netmask('1.2.3.4', -1) , and then the state of the netmask object includes a bitmask <0, and size > 2^32 among other oddities. The next() operation has an uncaught error in this case.
   (b) Try weird2 = new Netmask('1.2.3.4', 0.1). The constructor succeeds, but the state is similarly funky.

Best regards,
Alon Navon,
Seal Security

When I'm trying to use the forEach method, I only get back 'fn is not a function'. No matter what input I use.

What exactly am I supposed to input? The documentation shows ip, long, index. Not sure what long or index means, so I've been guessing.

what kind of function am I supposed to input into the forEach method?

Just tested on windows and got a File not found: lib/*.coffee

Tell the author that this fails on your system:
    coffee -c lib/*.coffee

Another helper method to get the list of ip addresses in a block as an array. I can submit a request if interested.

// assuming block is a netmask object
function addresses(block) {
    // array of ips to be returned
    var arr = [];

    // first ip address in long form
    var firstLong = ip2long(block.first);
    // last ip address in long form
    var lastLong = ip2long(block.last);

    // first ip is already in nice ip form
    arr.push(block.first);
    // check if first and last ip is the same
    if (block.first != block.last) {
        for (var i=firstLong+1; i<lastLong; i++) {
            arr.push(
                long2ip(i)
            );
        }
        // last ip is already in nice ip form
        arr.push(block.last);
    }

    return arr;
}

Any thought about IPv6?

If input ip addr or netmask is invalid, it will throw error, then I must use nested try / catch to handle that.
It makes code complicated.
I suggest return a undefined / null value for calculate error. Like behavior of many JS native functions.

The latest version on npm (v0.0.2) is from June 21, 2012. There's been a handful of new commits since then.

Would you mind publishing a v0.0.3 on npm when you get a chance? Cheers!

This is an awesome module for creating IP ranges from a given netmask, but it'd be even better if it worked in reverse, eg:

coffee> n = new netmask.Netmask('10.0.0.0/24')
{ bitmask: 24,
maskLong: 4294967040,
netLong: 167772160,
size: 256,
base: '10.0.0.0',
mask: '255.255.255.0',
hostmask: '0.0.0.255',
first: '10.0.0.1',
last: '10.0.0.254',
broadcast: '10.0.0.255' }

coffee> n = new netmask.Netmask('10.0.0.1', '10.0.0.254')
{ bitmask: 24,
maskLong: 4294967040,
netLong: 167772160,
size: 256,
base: '10.0.0.0',
mask: '255.255.255.0',
hostmask: '0.0.0.255',
first: '10.0.0.1',
last: '10.0.0.254',
broadcast: '10.0.0.255' }

const block = new Netmask('224.0.0.0/4');
console.log(block);
block.forEach(someFunction);

Netmask {
  bitmask: 4,
  maskLong: 4026531840,
  netLong: 3758096384,
  size: 268435456,
  base: '224.0.0.0',
  mask: '240.0.0.0',
  hostmask: '15.255.255.255',
  first: '224.0.0.1',
  last: '239.255.255.254',
  broadcast: '239.255.255.255' }

FATAL ERROR: invalid array length Allocation failed - JavaScript heap out of memory

The last IP address of a block should end with .255 but last() returns an IP address of .254.

The Perl Net::Netmask, upon which this is based, says in the documentation: "->first() & ->last() Synonyms for ->base() and ->broadcast()" and base should return the base address of the network block and broadcast should return the last IP address.

The code
@last = if @bitmask <= 30 then long2ip(@netlong + @SiZe - 2) else long2ip(@netlong + @SiZe - 1)
should be moved after @broadcast is set and changed to
@last =@broadcast

In common usage, the first address in a subnet, all binary zero in the host identifier, is reserved for referring to the network itself, while the last address, all binary one in the host identifier, is used as a broadcast address for the network; this reduces the number of addresses available for hosts by 2.

While this is true, the actual CIDR range consists of the full set of IP addresses in the range even if those two IP address shouldn't be assigned to host machines.