rtheil / pseudo-md-doc-web Goto Github PK

Get rid of console.log entries where unnecessary and not showing errors

Add a footer to the entire site with a few links on it

The set-env command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

After review, this is caused by webapps-deploy@v2, and also affects the MD-doc-API project. The issue has been reported and labeled as Triage: Azure/webapps-deploy#70

Wait for next version of webapps-deploy

Navbar menu doesn't collapse like it should. It's missing something. Convert the navbar to react-bootstrap

Submit forgot password and get error. Submit again and get success, error still shows.

Convert them all to be up to latest react stuff now that we've learned the class component way. Most are already done.

Left to do:

• forgotForm

• loginForm

• registerForm

Design a workflow process to move the new applicants through the process as their status changes. Their status can be "New", "Background Check Pending", "Test Pending", "Failed Test" or "Offer".

Make a change to persist the Redux state for user login so page refreshes keep people logged in. Make sure to tie this to the login checkbox to save login.

Jeremy's bugs (Applications)

Application Form

• can type more than 9 digits in ssn

• middle initial is still required

• no choice on drop down gives no error when empty (it's an empty string)

• no error shown when no API response

• add and delete buttons need to be aligned

• API Error from no submit

• education/empl/ref fields clear if any error when adding

• limit date field to 4 digits in year

• add max() to Joi schema for many fields (match to database)

Sentry

• Need to better pass http errors to sentry. API error should be there.

My Account Page

• prev error stays after a success

• change password field name to newPassword

• clear password fields after successful password update

Add the ability to sort applications by the available columns

Should show an error when trying to submit an app without employment, education, or references

If token expires, user is stuck and must log out and back in

Login, forgot password, registration, reset password, new application, all have auto-values in state

I hate the way items are added to these multi-item lists.

Instead: List of items added with a + button to add another, then fields show to add new item, Add button clicked to add then fields hide

We need a few more things to make the admin's applications page a bit more usable for a large number of applications

LIST:

• Colors on application status

• Application ID?

• Delete button

FILTERS

• Filters for showing applications in specific stages

• Name search filter

• Date Filter?

• All employer fields but employer name do not highlight when there's an error

• drop downs can't be anything but true

• Checks on dates for valid range (start date before end date)

• Education degree field doesn't show error

Need to replace @hapi/joi with the joi npm package https://www.npmjs.com/package/joi

Add admin area for application admin

TextInput component is all wrong. Needs to be modified to properly use ...rest and eliminate some of the size issues put in place due to misunderstand of the sm tag and others such as "as=Col"

For proper flow, we need to establish where the user was before being forced to log in or registering, so that after the user logs in, they are taken to that page.

For example, if user is looking at a job description, and clicks the "Apply" button, and is taken to the /applications/new url, which will forward to /login, we should remember the /applications/new url so that after login or registration the user ends up there.

There are more errors than invalid user/password. Error should show if account not verified, or if can't contact server

Test plan

Logging in and out

1. go to https://md-doc-web.azurewebsites.net/
2. create an account (must use real email address)
3. verify account through email (check spam folder)
4. log in to account
5. log out
6. use forgot password process
7. click link in email (check spam folder)
8. update password
9. log in again

Submitting an Application

1. Create a new application: top-right navbar > Job Postings > Apply Now button
2. Submit one or more applications
3. Go to "Account Detail" page (top right of navbar)
4. Make sure you can see your submitted applications and their status
5. View the application and make sure proper application status is showing and that admin tools are not showing
6. log out

Update Account Information

1. Go to "Account Detail" page (top right of navbar)
2. At left, attempt to update your name and email address
3. Attempt to change password

Administrator functions and application reviewing

1. log in as an administrator
2. Go to All Applications page (top-right of navbar)
3. Check usage of all filters
4. check usage of all sorting
5. Attempt to delete application, make sure both yes and no buttons work
6. View an application that has a "New" status
7. Click "Background Check Submitted" button. Status should become "Background Check Pending"
8. Test both "Background Check Passed" and "Background Check Failed" buttons on multiple applications
   AFTER BACKGROUND CHECK PASSED:
9. Enter the applicant's test score. greater or equal to 60 should result in "Offer" status. Less than 60 should result in "Failed Test" status

That's it?

Admin part is all done but the end-user needs status information at top.

After clicking to submit application, a delay makes you wonder if it worked. Disable the button. Add a spinner. Check for errors if server not reachable. re-enable button when needed