rubenwardy / crafting Goto Github PK

Actual for version 75c9240
As far as I understand, function crafting.make_result_selector is called on each update of player inventory: on opening, on filtering and on switching pages.
It does a lot of string concatenation, which can be avoided.

I propose to store inventory formspecs in special array in crafting object for each filtering query and for each inventory page.
It will take more server memory at the cost of speed of construction inventory screen window

Players have a crafting level which effects how fast and how good what they make is.

Maybe not for simple inventory / workbench crafts, but for more skilled tasks such as sword smithing, clothes, furniture, and art.

CSM could be used to craft using the normal mechanism

under server 5.2.0
client : unknown
story : not known, there is no clear action could explain who or what

mod : cf1ad1b/09.05.2017

guessing, typical client change IP or just disappeared gamer during mod started ...

2022-02-21 22:16:38: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'crafting' in callback nodemeta_inventory_OnTake(): /home/thomas/.minetest/mods/crafting/util.lua:537: attempt to get length of local 'recipes' (a nil value) 2022-02-21 22:16:38: ERROR[Main]: stack traceback: 2022-02-21 22:16:38: ERROR[Main]: /home/thomas/.minetest/mods/crafting/util.lua:537: in function 'get_crafting_result' 2022-02-21 22:16:38: ERROR[Main]: /home/thomas/.minetest/mods/crafting/table.lua:78: in function 'take_craft' 2022-02-21 22:16:38: ERROR[Main]:

Not sure how to do this. Games may want tech trees or just random unlocks, it's better to provide a nice API for this

I'd like to ask for a feature to group output items so that multiple recipes with the same output gets only one entry in the crafts table.

Like this, as an example:

Now, obviously I didn’t manage to combine several identical ingredients into one so with better code the tooltip will of course be much shorter.

Make fuel optional, custom flame animation texture

log:

2020-02-24 08:53:55: ERROR[Main]: ModError: Failed to load and run script from /root/.minetest/games/ctf/mods/other/crafting/init.lua:
2020-02-24 08:53:55: ERROR[Main]: /root/.minetest/games/ctf/mods/other/crafting/stations.lua:55: bad argument #1 to 'pairs' (value expected)
2020-02-24 08:53:55: ERROR[Main]: stack traceback:
2020-02-24 08:53:55: ERROR[Main]: 	[C]: in function 'pairs'
2020-02-24 08:53:55: ERROR[Main]: 	/root/.minetest/games/ctf/mods/other/crafting/stations.lua:55: in function 'check_for_changes'
2020-02-24 08:53:55: ERROR[Main]: 	/root/.minetest/games/ctf/mods/other/crafting/stations.lua:67: in main chunk
2020-02-24 08:53:55: ERROR[Main]: 	[C]: in function 'dofile'
2020-02-24 08:53:55: ERROR[Main]: 	/root/.minetest/games/ctf/mods/other/crafting/init.lua:22: in main chunk

(minetest/minetest#9428)

When you change the output amount, for example unlocks_crafts = { "crafts:plant_fibre" } to unlocks_crafts = { "crafts:plant_fibre" 3 }, you create a potential domino effect where the next recipe in a chain might not set always_known = true, and instead depend on an award to unlock it.

If the award in question has unlocks_crafts = { "crafts:plant_fibre" } in the trigger, all of a sudden it's broken and needs to be changed to unlocks_crafts = { "crafts:plant_fibre 3" }, due to the change in the crafting registration.

This could easily lead to unintentional breakages when trying to edit recipes for game balance.

A second issue due to this is that if you define two different crafting recipes for an item and making x amount of that item is the unlock for another recipe, you can't make sure the total needed for the unlock increments with each item made.

A better system would be to have crafting recipes unlock based on total made, not based on total uses of a given recipe.

eg: after digging nodes

For more complex crafts than you'd have in inventory

Something happened with the top player inventory row in crafting when using the crafting bench and similar stations. It's still visible in the sfinv tab but not in stations. Take a look at this clip (sfinv tab first, station second)

What could be causing this?

I've tried it both in 0.4.17.1 and in 0.5.0-dev with the same results.

It's silly to have a button for each type of tool. Making it so you can click a generic icon then see options would be better - like in terraria

It's currently only possible to complete a recipe once per click, which can quickly get less than user friendly.

Can we please add alternatives for bulk crafting? For example, either hold down to complete multiple times or have right/left/middle click trigger the recipe different numbers of times.

Should support multiple inputs for alloying, and a fuel slot, and have multiple outputs
One of the only machines you can leave running

It has happend to me twice. I had full inventory with 4 mese or more. Then I dug something and forgot that I have full inventory and I pressed "craft mese sword" button. And yay mese sword disappeared unknown where, so I didn't get it.
I think this is a bug because sword should be dropped and not wasted when you have full inventory.

With a player inventory alread full, crafting makes the output disappear, only to appear again once there's space available. See video.

For example, furnaces could have the levels:

1. basic station - level 1 recipes only
2. station - level 2 recipes plus the recipes of the above level 1 station
3. alien station - level 3 recipes plus the recipes of the above level 2 station

or whatever.

Recipes would then be defined like:

crafting.register_craft({
    type = "furnace",
    level = 2,   -- can be made on Level 2 or 3 furnaces
    output = "default:iron_ingot",
    items = { "default:iron_ore" }
})

Not trivial as you also need to search by type and level, and unlocked level