rulox / react-atomic-structure Goto Github PK

Now, components are used like this
<Label text="my text"/>

I'm realizing it should be most effective if they can be used like normal xml/html tags:
<Label>my text</Label>

It makes dev annoying to wait for the linter to test quick changes during dev

Thoughts? I feel we should be less strict as this is a boilerplate project and let the user to add/extend their own rules @Oliphaunte

In readme

Idea: Custom npm scripts to create atoms/molecules/organisms/templates ?

Small preference question, which do you prefer for var declarations:

var gulp = require('gulp');
var eslint = require('gulp-eslint');

or

var gulp = require('gulp'),
eslint = require('gulp-eslint');

@Rulox

npm install --save-dev file-loader

Should we also do code coverage? I think we should.

There are some tools out there, Jest/Mocha/Instanbul/Jasmine, etc...

Discussion opened! @Oliphaunte

We should add the lint for sass files in the travis yml.

Hola, descargue el proyecto e hice lo siguiente:

1. yarn upgrade
2. yarn start

Y no arranca me saca error

This is needed, also for contributions.

Maybe Yeoman or something similar can be used to refactor the project and instead of cloning the repo it can be used with a generator.

npm WARN [email protected] requires a peer of eslint@^3.5.0 but none was installed.
npm WARN [email protected] requires a peer of eslint@^3.5.0 but none was installed.

I'm not sure if this means it is not using the airbnb eslint or if we can ignore this. Should probably look into this at some point ¯\ (ツ) /¯

• Update npm scripts
• Add "creating new components" section

Hi, guys. First, nice job you've done here.

I have a similar project, but I'm always looking to find out what people have done with React, Atomic Design and other related stuff. It's not so easy to find implementations of Atomic Design in React though.

Taking a look at the project, I see that you don't have page components. Instead, use templates. I think those are the most confusing parts of Atomic Design (this approach, for example, replaces pages and templates for ecosystems and environments), so I wanted to know what do you guys think about it. Why did you decide to use only templates? Why not pages?

https://github.com/Rulox/react-atomic-structure/blob/master/Gulpfile.js

@Oliphaunte thoughts?

https://github.com/commissure/redbox-react

Inconstencies with gulp/webpack @Oliphaunte 😢