Extensions we use and maintain about awesome-magento2 HOT 3 CLOSED

Hi @eadesignro,

thanks for your recommendation, I will have a look on these (hopefully tonight) and come back with feedback.

from awesome-magento2.

Hi @eadesignro, I finally came to a small review. As you can see in the contribution Guide, I would like to see some minor changes. Most things are common and not a big deal to "fix" or "improve". It just makes sure, that everybody knows the purpose of the extension and knows how to install it.

Due to that, I created a small PR (EaDesgin/magento2-pdf-generator2#3) where I added three new sections to the Readme.

A battle proofed and standard way to make things more clear is to use badges. You might want to checkout http://shields.io/ to generate some for your Repositories.

The contribution guide also points to a point, where code should be tested. I do not force contributors to add tests, but I would love to see the major parts of the extension tested.

Please check out the Contribution Guide.

This is, what I would say, a best practice extension for the M2 Awesome List. You might want to check it out:

• https://github.com/yireo/Yireo_Whoops
• https://github.com/ebizmarts/magento2-magemonkey

In Summary:

• Readme Improvements (Badges can help)
• Add some Unit or Integration Tests to make sure, the core of the Functionality works well. If this would be done later, it's ok. I will do my best to also add a few PR's to your Extensions!

Thanks for your recommendations.

PS: I love your Videos! This is what makes Magento 2 Awesome!

from awesome-magento2.

Hi,

Thanks for the effort and time spent. We can close the issue now.

P.S. During the spring we are swamped with work but unit testing is must!

from awesome-magento2.