Comments (1)
This is almost the usual -- code doesn't type check and yet gets fed to the interpreter. Cc @oli-obk @lcnr
However, the twist here is that we're calling the interpreter in dump-mir. In the past I think we made some effort to make dump-mir work even on some invalid data. This is fairly easy for data that's "just" UB but still structurally valid; however, the case here is different. Maybe dump-mir (or try_destructure_mir_constant_for_user_output
) should check if the MIR body is involved in type errors, and if it is then avoid calling interpreter methods?
Or alternatively we'll have to carefully audit everything reachable from try_destructure_mir_constant_for_user_output
and make it throw_inval!
some suitable error that can be ignored further up.
from rust.
Related Issues (20)
- pre-push hook should only look at staged changes
- `No bound vars found for HirId(DefId(` in compiler/rustc_middle/src/ty/context.rs
- assertion `left == right` failed HOT 2
- rustdoc ignores `cargo` and linker settings when compiling doc tests HOT 1
- Rust 1.78 Does Not Return c_void Pointer Correctly HOT 8
- Incorrect error when polling non-pinned future from future wrapper
- "--json-output" is ignored by tool builds HOT 2
- ICE: `still mutable` HOT 2
- ICE: mir build: scope: `index out of bounds: the len is 0 but the index is 0` HOT 6
- ICE: mir_build: `no entry found for key` HOT 2
- ICE: const: body_owned_by expr `const ..` has no associated body
- Encountered incremental compilation error with find_field(a5f984281f1e0bb0-ee8ea99685b18732) HOT 5
- ICE: `offset of unsized field (type dyn [Binder(Trait(std::fmt::Debug), [])] + '{erased}) cannot be computed statically` HOT 1
- `non_local_definitions` triggers on macro-generated code HOT 14
- `E0277` Emitted Twice HOT 1
- Tracking Issue for `new_range_api` (part of RFC 3550) HOT 4
- Cannot write tests that need the csky backend HOT 5
- Inconsistent recursive fn call elimination HOT 15
- run-make-support: add `#[must_use]` to helpers where suitable HOT 2
- Tracking Issue for `--print=check-cfg`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust.