Verification <input t

Tests relying on `reqwest::Client` may fail with "dispatch task is gone: runtime dropped the dispatch task" about rustup HOT 1 OPEN

rami3l commented on July 17, 2024

Tests relying on `reqwest::Client` may fail with "dispatch task is gone: runtime dropped the dispatch task"

from rustup.

Comments (1)

rami3l commented on July 17, 2024

According to the error message format and my IDE searching the current codebase, this is a RustupError::DownloadingFile. This kind error message can only be emitted from here:

rustup/src/utils/utils.rs

Lines 154 to 190 in 6d43761

 pub(crate) async fn download_file_with_resume( 

 url: &Url, 

 path: &Path, 

 hasher: Option<&mut Sha256>, 

 resume_from_partial: bool, 

 notify_handler: &dyn Fn(Notification<'_>), 

 ) -> Result<()> { 

 use download::DownloadError as DEK; 

 match download_file_(url, path, hasher, resume_from_partial, notify_handler).await { 

 Ok(_) => Ok(()), 

 Err(e) => { 

 if e.downcast_ref::<std::io::Error>().is_some() { 

 return Err(e); 

 } 

 let is_client_error = match e.downcast_ref::<DEK>() { 

 // Specifically treat the bad partial range error as not our 

 // fault in case it was something odd which happened. 

 Some(DEK::HttpStatus(416)) => false, 

 Some(DEK::HttpStatus(400..=499)) | Some(DEK::FileNotFound) => true, 

 _ => false, 

 }; 

 Err(e).with_context(|| { 

 if is_client_error { 

 RustupError::DownloadNotExists { 

 url: url.clone(), 

 path: path.to_path_buf(), 

 } 

 } else { 

 RustupError::DownloadingFile { 

 url: url.clone(), 

 path: path.to_path_buf(), 

 } 

 } 

 }) 

 } 

 } 

 }

from rustup.

Tests relying on `reqwest::Client` may fail with "dispatch task is gone: runtime dropped the dispatch task" about rustup HOT 1 OPEN

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	pub(crate) async fn download_file_with_resume(
	url: &Url,
	path: &Path,
	hasher: Option<&mut Sha256>,
	resume_from_partial: bool,
	notify_handler: &dyn Fn(Notification<'_>),
	) -> Result<()> {
	use download::DownloadError as DEK;
	match download_file_(url, path, hasher, resume_from_partial, notify_handler).await {
	Ok(_) => Ok(()),
	Err(e) => {
	if e.downcast_ref::<std::io::Error>().is_some() {
	return Err(e);
	}
	let is_client_error = match e.downcast_ref::<DEK>() {
	// Specifically treat the bad partial range error as not our
	// fault in case it was something odd which happened.
	Some(DEK::HttpStatus(416)) => false,
	Some(DEK::HttpStatus(400..=499)) \| Some(DEK::FileNotFound) => true,
	_ => false,
	};
	Err(e).with_context(\|\| {
	if is_client_error {
	RustupError::DownloadNotExists {
	url: url.clone(),
	path: path.to_path_buf(),
	}
	} else {
	RustupError::DownloadingFile {
	url: url.clone(),
	path: path.to_path_buf(),
	}
	}
	})
	}
	}
	}