rustcrypto / sponges Goto Github PK

I think it would be better if the keccak::f1600 function explicitly took a byte array, rather than taking an array of 64-bit words.

The reason is that this allows the keccak crate to provide endianness handling internally, rather than forcing every client crate to handle it themselves (or just leaves them to not handle it at all).

• Keccak variants: generic keccak-p and other sizes for keccak-f (200, 400, 800)

I don't quite understand what sponge function means in this repo. It looks like a one-way permutation, not a construction/mode of operation?

Ran into that this crate is licensed under the not so common CC0 license, which Open Software Institute does not recommend, so I/we generally try to avoid it as well.

Would it be possible to re-license this crate under the standard Rust MIT OR Apache-2.0? Like all the other RustCrypto crates?

Looks like @newpavlov have been the only contributor to this crate so far which would make it easy to change.

It looks like when the keccak crate was relicensed, the old LICENSE file was not removed. For some baffling reason (???), the file was also not included in published crates, but with version 0.1.3, the .crate file published and redistributed on crates.io includes the LICENSE file again.