rustls / pemfile Goto Github PK

View Code? Open in Web Editor NEW

48.0 9.0 17.0 87 KB

Basic parser for PEM formatted keys and certificates

License: Other

Rust 100.00%

rustls-pemfile rust

pemfile's People

Contributors

Stargazers

Watchers

Forkers

dgkh1975 zz85 briansmith lulf farcaller icodein stu-h cpu will-low japaric complexspaces stevefan1999-personal marlonbaeten nneesshh ologbonowiwi tudyx alex

pemfile's Issues

Handle PKCS12 files

Hi, how could I load a PKCS12 file ~~with a password~~ for use in rustls? Edit: I see this library doesn't support PKCS8 with passwords.

I see there used to be a rustls::internal::pemfile::pkcs12_import function, and there's a function for loading a pkcs8 file.

I'm resorting to loading the PKCS12 with the openssl crate, then re-encoding that to a PEM &[u8] that I pass to rustls. Is there another way?

Document breaking changes with

Per 6f0724b

These breaking changes were done, but not listed in the release notes. Please add the following text to the release page:

Renamed `Item::{RSAKey, PKCS8Key, ECKey}` to `Item::{Pkcs1Key, Pkcs8Key, Sec1Key}`

Could you add some examples?

Hi, normally I use tokio-tungstenite for ws stream, but I need wss stream. I have fullchain and privatekey pem files where I got from let's encrypt. Here is my normal code:

let socket = TcpListener::bind("192.168.1.2:2424").await.unwrap();
    let streamer_socket = TcpListener::bind("192.168.1.2:2525").await.unwrap();
        match streamer_socket.accept().await {
            Ok((streamer_tcp, streamer_info)) => {
                match tokio_tungstenite::accept_async(streamer_tcp).await {
                    Ok(ws_stream) => {
                        tokio::spawn(streamer_stream(ws_stream));
                    },
                    Err(err_val) => eprintln!("Error: TCP to WS Transform | {}", err_val),
                }

could this crate help me to convert this stream to wss with pem files ? If yes how ?

Certificates with indentation fail to parse

Example cert:

OpenSSL can load it via openssl x509 -in cert.crt -noout -text, so it is valid. Trying to parse this with rustls-pemfile (via rustls-native-certs) creates an error similar to this.

{ kind: InvalidData, error: "Could not load PEM file \"/usr/lib/ssl/certs/ca-certificates.crt\": Invalid byte 32, offset 0." }

EC private keys

Example private key file for secp384r1:

The extract function isn't exported :/

Can you add a function for EC private keys?

Incorrect parsing of private key by rustls_pemfile::private_key

The private_key read from the file is of type PrivateKeyDer::Pkcs8(PrivatePkcs1KeyDer(...))
The private_key and key added using include_str! doesn't assert

Generate Private Key

openssl genrsa -out private.key 2048

use std::{fs::File, io::BufReader};
use rustls::pki_types::{PrivateKeyDer, PrivatePkcs1KeyDer, PrivatePkcs8KeyDer};

const PRIVATE_KEY: &str = include_str!("./private.key");

fn main() {
    let private_key_file = "./private.key";
    let private_key: PrivateKeyDer = rustls_pemfile::private_key(&mut BufReader::new(&mut File::open(private_key_file).unwrap())).unwrap().unwrap();
    dbg!(&private_key); // Pkcs8(PrivatePkcs1KeyDer(..)) ?

    let new_key: PrivatePkcs8KeyDer = PRIVATE_KEY.as_bytes().into();
    let new_key_as_enum: PrivateKeyDer  = new_key.into();
    dbg!(&new_key_as_enum);
    assert_eq!(private_key, new_key_as_enum); // Assertion Failed
}

Provide a function to extract private keys in any format

I had a use case the other day where I needed to parse some private keys of various formats. I had to write a bit of match logic to extract the bytes for the appropriate key type, even though I didn't care about which key type it was. I think this would be a relatively common use-case.

What would you folks think about providing a function to parse all private keys in any format, returning a Result<Vec<Vec<u8>>, Error>?

Version 1.0.2 broke semver

The v1.0.2 upgrade included an upgrade of the base64 dependency from 0.13 -> 0.21. This implies that, to follow semantic versioning rules, the release should have been 1.1.0

Folks trying to build your crate with a version of Rust that does not support edition 2021 now have to pin the version to 1.0.1 in order to be able to build.

Cannot read Let's Encrypt's private key

The read_one fn can not read Let's Encrypt's RSA private key

Code:

pub fn rsa_private_keys(rd: &mut dyn io::BufRead) -> Result<Vec<Vec<u8>>, io::Error> {
    let mut keys = Vec::<Vec<u8>>::new();

    loop {
        match read_one(rd)? {
            None => return Ok(keys),
            Some(Item::RSAKey(key)) => keys.push(key),
            _ => {}
        };
    }
}

Key file:

Provide function to load a PEM file?

With a name of "pemfile" it's expected to to able to read a PEM file, no?

rustls pemfile do not open encrypted private key

I'm trying to open a encrypted private key with the rustls_pemfile lib, but i am always receiving a empty vector.
I used this command to generate the encrypt private key:
openssl genrsa -aes-128-cbc -out ca.key 2048

A encrypted private key has a password. Is there any way to open this kind of private key passing the password in this lib?

The file init is:
-----BEGIN ENCRYPTED PRIVATE KEY-----

That's important, because new standards, such as modbus security, has the default chiper TLS_RSA_WITH_AES_128_CBC_SHA256, which is encrypted.

Thanks in advance

rustls / pemfile Goto Github PK

pemfile's People

Contributors

Stargazers

Watchers

Forkers

pemfile's Issues

Handle PKCS12 files

Document breaking changes with

Could you add some examples?

Certificates with indentation fail to parse

EC private keys

Incorrect parsing of private key by rustls_pemfile::private_key

Provide a function to extract private keys in any format

Version 1.0.2 broke semver

Cannot read Let's Encrypt's private key

Provide function to load a PEM file?

rustls pemfile do not open encrypted private key

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent