rvikmanis / redux-fp Goto Github PK

When trying to import using destructing pattern it fails:

import { handleAction } from 'redux-fp' // handleAction is undefined

Can be fixed by using .js version instead of .mjs in package.json.

Hi,

What about a matchAction function ?

Like match, but instead of taking a predicate updater, just taking a simple action predicate.

implementation

const { match } = require('redux-fp');

const matchAction = (predicate, leftUpdater, rightUpdater) => (
  match((action) => () => predicate(action), leftUpdater, rightUpdater)
);

module.exports = matchAction;

example

const R = require('ramda');
const { matchAction } = require('redux-fp');

const handleDebug = matchAction(R.path(['meta', 'debug']))
const logsReducer = handleDebug(action => R.concat([action]));

Does that sound right ?
Can I make a PR ?

By the way, thanks for this awesome elm-ish redux library.
I'm enjoying using it to implement updaters with ramda and ramda-adjunct

As per this line, it appears that a new state object is always returned, even if passed an action type which isn't handled by any updater (or if it is handled, but the same state is returned). This can have a negative effect on performance, since it can trigger unneeded selector calculations and even re-renders, if connected improperly + it renders some tools useless, like redux-unhandled-action.

Do you see this as unwanted behavior, and if so, are you interested in fixing it?