rvyuha / smallcellcheck Goto Github PK

A common programming style for R is to use apply family, instead of nested for loops.

Where there any design considerations for you to use nested for loops? What are pro/cons of using one approach over another?

(A totally reasonable answer could be that you've come from a programming environment where you've mostly used for loops. But I thought that your lamba background and CS courses may have discussed the approach). https://www.datacamp.com/community/tutorials/r-tutorial-apply-family.

I didn't follow the purpose of this line of code and/or the meaning of the variable bla. Could you explain? Possible with a comment in the code?

https://github.com/DarkShadeKnigh/SmallCellCheck/blob/master/R/table-one.R#L20

Note that when there are no small cell sizes the metadata returns this:

TableOne[["MetaData"]][["small_cells"]][["variable_name"]]
factor(0)
Levels: bla

What considerations did you have for the situation where there are no small cell sizes? Currently, I receive the output:

Warning in `[<-.data.frame`(`*tmp*`, is_list, value = list(`2` = "<>")) :
  replacement element 1 has 1 row to replace 0 rows

Mostly curious: did you follow any R style guides or use a linter or styler?

Note that we are following the tidyverse style guide.

https://github.com/Big-Life-Lab/Welcome/blob/master/being-consistent-resources.md