rxnlabs / wp-composer Goto Github PK

In some environments, after running a command and getting a success message from WP-CLI, the success messages gets outputted twice.

Example:

Sometimes the composer.json file will be saved to the directory where the wp-cli command was run from. The composer.json file should always be saved to the same place (preferably the site root).

This occurs when using commands such as:

wp plugin install akismet
wp theme install twentysixteen

A new composer.json file will be created in the directory where the command was run.

I run the command with a path to my wp directory as such:

wp --path='web/' composer add

After 10 seconds or so I just get the message back:

Killed

No errors. Any ideas?

i updated to the latest version and my composer.json file is emptied out:

$ wp plugin install wordpress-importer --activate
Installing WordPress Importer (0.6.3)
Downloading install package from https://downloads.wordpress.org/plugin/wordpress-importer.0.6.3.zip...
Using cached file '/Users/ben/.wp-cli/cache/plugin/wordpress-importer-0.6.3.zip'...
Unpacking the package...
Installing the plugin...
Plugin installed successfully.
Activating 'wordpress-importer'...
Plugin 'wordpress-importer' activated.
Success: Installed 1 of 1 plugins.
Adding plugin wordpress-importer. Using version *
PHP Warning:  json_encode() expects parameter 2 to be integer, string given in /Users/ben/.wp-cli/packages/vendor/camspiers/json-pretty/src/Camspiers/JsonPretty/JsonPretty.php on line 25
Warning: json_encode() expects parameter 2 to be integer, string given in /Users/ben/.wp-cli/packages/vendor/camspiers/json-pretty/src/Camspiers/JsonPretty/JsonPretty.php on line 25
Success: Saved wordpress-importer plugin as a dependency to /Users/ben/Sites/valet/bedrock/composer.json

my composer.json was originally just the stock one from bedrock: https://github.com/roots/bedrock/blob/master/composer.json

Without write permission composer.json is not created and there is no error message.

Functional tests are an integral ingredient of highly-quality, maintainable commands. WP-CLI tries to make it as easy as possible to add functional tests to your package with its wp scaffold package-tests command:

https://github.com/wp-cli/scaffold-package-command#wp-scaffold-package-tests

I'd encourage you to consider adding functional tests to your package :) By starting your functional tests early on, it also makes it much easier to maintain your project over time.

What went well, and what could be improved? Any documentation changes you'd suggest?