ryanberckmans / already-seen Goto Github PK

jQuery is used only for CSS selectors. Remove dependency on jQuery by using native APIs like querySelectorAll.

Author: u/AyrA_ch https://www.reddit.com/r/GreaseMonkey/comments/amai2g/autohide_reddit_links_after_youve_seen_them_once/efl4ry1/

Currently, when storage is full, 25% of seen links are erased. Due to an implementation detail these 25% are typically the least recently used/seen.

Formalize "least recently used" as follows

• The storage data structure should be converted to [StoredEntry], where StoredEntry is an object containing at least key: string and lastSeen: UnixTimestamp
• StoredEntry is a backwards incompatible change for current [string] schema; the storage loader should add a "live migration" so that any previously stored links are migrated to the new data structure
• A hardcoded number of links should be retained in storage, maybe 5000. Potentially this number could be much higher if #3 is completed.
• Potentially links should automatically be erased if they were last seen prior to (now minus a hardcoded duration). Because users may want to see links they saw eg. 6 months ago if they come up again in pop culture, potentially in a new context or with new discussion.
• When attempting to save more links than allowed, the least recently used links should be erased.
• Prior to save, when merging links currently on page with previously seen links, the newer lastSeen should be retained.
  • Currently this algorithm is just a Set construction const entryKeysAlreadySeenIncludingNewOnesOnThisPage = Array.from(new Set(entryKeysAlreadySeen.concat(allEntriesOnPage.map((e) => e.key))));

"If people have configured their browser to purge cookies on exit, localStorage is wiped, too. Tampermonkey provides an internal mechanism at GM_getValue and GM_setValue (doc) that persists and is not counted towards the page store size."

Author: u/AyrA_ch https://www.reddit.com/r/GreaseMonkey/comments/amai2g/autohide_reddit_links_after_youve_seen_them_once/efl4ry1/

I'd be interested to support localStorage as well, perhaps as follows:

1. refactor current localStorage method to use something like a Storage interface
2. implement Storage for GM_getValue/GM_setValue and make this the default Storage implementation

Generate dist/already-seen.meta.js in the build. This file should just be a copy of the header comment block in dist/already-seen.user.js.

https://openuserjs.org/about/Frequently-Asked-Questions --> search for "meta.js"

Author: u/AyrA_ch https://www.reddit.com/r/GreaseMonkey/comments/amai2g/autohide_reddit_links_after_youve_seen_them_once/efl4ry1/

"Don't minify the script. People don't like installing scripts they can't read directly (nobody knows if your dist is really made from src)."

This may involve swapping closure-compiler for another build tool.

Author: u/AyrA_ch https://www.reddit.com/r/GreaseMonkey/comments/amai2g/autohide_reddit_links_after_youve_seen_them_once/efl4ry1/