ryanflorence / publisher.js Goto Github PK

When run as an AMD module and optimized by @jrburke 's RequireJS, Publisher fails to be defined as a module. Instead an empty define('publisher', function(){}) is produced, breaking any code Publisher-dependent code.

Quoting @jrburke from ded/morpheus#19 , in which an identical problem and its solution are discussed:

The issue is that the requirejs optimizer uses an AST to find define() calls that look like AMD define calls. Since define(definition) is a bit too generic it skips it and puts in an empty module for the 'morpheus' name.

Two possible easy fixes:

1. Use a function literal:

if (typeof define == 'function') define(function(){return definition()})

2. Or just pass name to the function:

if (typeof define == 'function') define(name, definition)

Whats currently missing is a way to subscribe to all messages of a topic or even all messages flowing to publisher to log them. This could be useful for automatically do something with sub topics which the system dosent know before.

An possible way to do this, would be something like that:

publisher.subscribe('sensors/*', function(data){
..
});

Please say it isn't so

the registration of an after callback is currently function(returnValue, object), ideally it should be something like function(returnValue, object, arg1, arg2, …) so that you can access the arguments without having to also create a before and cache them.