ryannielson / meta Goto Github PK

Meta.php:

    private function metaTag($name, $content)
    {
        if(substr($name, 0, 3) == 'og:')
            return "<meta property=\"$name\" content=\"$content\"/>";
        else
            return "<meta name=\"$name\" content=\"$content\"/>";
    }

$content should be htmlentities(...)-escaped before output to fit inside an attribute.

Fix should be as easy as:
$content = e($content);
... unless you need to be backwards-compatible, in which case you'd have to test for any encoded chars and encode/do nothing accordingly.

• Use array_pull() instead of custom method to remove array elements.
• Remove special cases for description and title since they behave like any other attribute.

Please update your installation instructions to mention the latest version of this package: 1.1.*

Currently the title tags show up as:-

<meta name="title" content="This is the page title.">

However, this doesn't show up either at the top of a browser's chrome nor in its tabs. A better way of printing them on the screen would be:-

<title>This is the page title</title>

The current approach of printing meta tags has a few downsides too. For more info you can have a look at this answer on stackoverflow.