ryanstull / scalanullsafe Goto Github PK

If there is a function call in the expression passed to the macros: i.e:

?(SomeFunc(a.b).c)

Currently the macros will fail, but the macros could handle this case if it considers the function as part of the first transformation. I.e.

if (a!=null){
    val b_prime = SomeFunc(a.b)
    if(b_prime != null) {
       b_prime.c
    } else null
} else null

Currently there's no equivalent in ScalaNullSafe for

Option(a).flatmap(a => f(a))

In other words, you can't use the result of a null-safe selection in a function call.

Adding the .? extension method to all AnyRef objects would solve this issue.

?(a.asInstanceOf[A].b) will fail.

val a: String = null
?(a.toInt) // throws NumberFormatException

The above snippet fails due to Scala wrapping a in an implicit class and the macro not knowing how to check for null properly in this instance. The snippet below is what the above code compiles to. The macro should instead check if a is != null and apply the wrapper in the body of the if.

{
  <synthetic> val fresh$macro$1: scala.collection.StringOps = scala.Predef.augmentString(a);
  if (fresh$macro$1.$bang$eq(null))
    fresh$macro$1.toInt
  else
    null
}

Currently ? and ?? have different syntax for default args. They should ideally be the same.

Compare against:

Simple access (Unsafe)
Manual full safety
Option flatmap
For loop, option flatmap
Nullsafe navigator lambda
Simple catch NPE