Comments (4)
Hmm... sort of, but this feels pretty like it would cause unexpected problems that would be really hard to figure out what went wrong. Plus, then we'd have to support !field.nil?
to produce an IS NOT NULL
query.
I would rather add is_null(field)
and is_not_null(field)
from baby_squeel.
One problem with field == nil
is that RuboCop keeps trying to replace it with .nil?
!
from baby_squeel.
Yeah, the initial reason why I proposed this change was Rubocop complaining. I feel kinda stupid not thinking about !field.nil?
, that's a more legit concern than whatever I have.
tbh, is_null
or is_not_null
, while it would please rubocop, would in my opinion be a step in the wrong direction. A better thing would be to have @bbatsov et al join in, to think about the possibility to provide a custom rubocop plug with your gem, or – more generally – if there's anything that would help accommodate cases (a/o DSL) where the ==
operator gets overloaded.
Besides, Rubocop also complains about == 0
. And making an is_zero?(field)
and is_not_zero?(field)
, would be even more unnecessary.
from baby_squeel.
One problem with field == nil is that RuboCop keeps trying to replace it with .nil? !
That's configurable. :) Obviously a static analyzer can't really figure out that something might be a special DSL. I think in such situations you can just exclude the DSL files from the checks and be done with it.
from baby_squeel.
Related Issues (20)
- Broken image in README.md HOT 2
- Breaks with Rails 6.0.0 HOT 28
- Breaks all Rails 5 has_many through relationship HOT 2
- Wrong table name when joining a polymorphic table twice HOT 2
- left_joins performs INNER JOIN with ActiveRecord 6.1.4.4 HOT 4
- Nested merge-joins query causes NoMethodError with ActiveRecord 6.1.4.4 HOT 3
- The 5.2 Builds are failing with the latest ransack version. HOT 1
- subqueries comparing with same table impossible HOT 1
- Jsonb Selectors HOT 2
- Support Arel.star HOT 1
- Reordering without explicit direction doesn't work with last in Rails 4 HOT 1
- Rails 5.2 support HOT 5
- Reference parent columns from subquery HOT 3
- Arel Deprecation Warning with Rails 5.2 HOT 2
- Intelligent Update queries
- Sifters don't work on on-the-fly tables
- Gem breaking with Rails 5.2.1 HOT 1
- Breaks with Rails 5.2.1 HOT 57
- Boolean casting goes haywire when using SQL alias HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baby_squeel.