Giter VIP home page Giter VIP logo

Comments (6)

StevenKal avatar StevenKal commented on July 30, 2024 1

Sorry I do not work for that "AMXX" thing, or except for money at worst. I know this reapi here is for it, I just take a ride to it sometimes because I follow it, but not more.
Adding a PR to both ReGameDLL_CS & this ReAPI is feasible, but gonna be dormant for months...
I can add the hook to both binaries (like, make a version for you), for a few euros, or, you can use module like Orpheu to memhack the GiveNamedItemEx.

from reapi.

StevenKal avatar StevenKal commented on July 30, 2024

Because game often uses "CBasePlayer::GiveNamedItemEx" instead. Resulting original "GiveNamedItem" not called as much as you expected. But it is still called in some buy events.

from reapi.

JohanCorn avatar JohanCorn commented on July 30, 2024

Because game often uses "CBasePlayer::GiveNamedItemEx" instead. Resulting original "GiveNamedItem" not called as much as you expected. But it is still called in some buy events.

I expected to work with rg_give_item native call. Should not work with that?

from reapi.

StevenKal avatar StevenKal commented on July 30, 2024

This native uses "GiveNamedItemEx" too, that's why, and yes, it is annoying.
Best on my opinion will be to improve original "GiveNamedItem" & remove the extended one, so all GiveNamedItems calls point to an unique function, and the hook catch it.
But maybe devs wanted to have this separated at the beginning (to differenciate original game calls from API's one), but some parts of the game were later updated to use the extended version, so this is confusing & a little mess with both.

from reapi.

JohanCorn avatar JohanCorn commented on July 30, 2024

Since we don't know what they want to do in the future. Maybe implementing a RG_CBasePlayer_GiveNamedItemEx hook should be the best option to keep it separated from the original. What do you think @StevenKal ? Can we make it and put in into a merge request? For my own purpose I will definitely code it (if possibble). I just want to know your opinion... Should we tag someone from the active developers to make the decision?

from reapi.

wopox1337 avatar wopox1337 commented on July 30, 2024

cuz s1lentq/ReGameDLL_CS#470 ?

from reapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.