s3rius / alarmix Goto Github PK

There is a way to rewrite this with set compressions. Should be more readable (subjective, ofc) and possibly faster.

Something like that (typing from phone, so look for errors/typos):

 self.alarms[When.auto.value] = {
   alarm_time for alarm_time in self.alarms[When.auto.value]
   if alarm_time >= datetime.now()
 }

Also datetime.now() calculated for every record in set. I don't think thats a problem, but something inside me screams when I see filtering with dynamic value 🙃

Why on earth should we depend on MPV? We have to replace it with pure python.

We have no tests, and any significant changes can break this project without any notice.

If you set up an alarm at 09:30 on weekdays.
You'll see it in a list even after buzzing.

➜  ~ alarmc          
+------------+----------------+
| alarm time | remaining time |
+------------+----------------+
|   15:35    |    0:36:02     |
|   09:30    |    18:31:02    |
+------------+----------------+

Some people might not understand how this project works. We need to update our README.rst and comments in code. And maybe we can describe alarmd socket protocol.

➜  ~ alarmc
+------------+----------------+
| alarm time | remaining time |
+------------+----------------+
|    9:30    |    20:56:53    |
+------------+----------------+

I hate it. Add padding zero at the start of hours and minutes if needed in order to achieve this:

➜  ~ alarmc
+------------+----------------+
| alarm time | remaining time |
+------------+----------------+
|    09:30   |    20:56:53    |
+------------+----------------+

Cuz, sometimes I don't quite remember what this alarm is for? And I guess the description will solve the problem.

We need to redesign our logo and update README.md.

Our current logo is just a simple free png of ringing watches. We need something more simple.