Giter VIP home page Giter VIP logo

chords's Introduction

Hi there ๐Ÿ‘‹

Top Langs

Stats

chords's People

Contributors

s4cha avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

o15a3d4l11s2

chords's Issues

Index out of bounds

If you try to show A#madd9 (I tested it in the ChordsApp) then the app crashes.
The problem is in func keyboardNoteType(forKeyboardNoteType noteType: KeyboardNoteType, interval: Interval) -> KeyboardNoteType, where newIndex is 24 and then becomes 12, which is out of bounds.

I though this could be fixed by doing % 12 instead of -= 12, but it causes a problem - the C note (9) should be on the next octave (see attached image)

I bought the ChordsApp few days ago and found this bug while using it. Then while searching for a feedback email I accidentally found the project on GitHub. I am still wrapping my head around the project. It looks quite interesting.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.