ToDo list in serendipity_event_spartacus.php about serendipity HOT 12 CLOSED

Hi!

I don't remember...maybe searching the code for "version_compare" should
yield this.

On 17.01.12 19:57, Ian wrote:

Hi

Is this part
- Perform Serendipity version checks to only install plugins available for version
of the header todo list still an issue ? If yes, we should proceed to have it, as we have in short serendipity version only templates as 2k11 and plugins like (no, I won't tell ya :-) )!

If it is build-in already, did anyone really see it it working (for templates and plugins) for sure?

---

Reply to this email directly or view it on GitHub:
#2

from serendipity.

Well, thank you responding, Garvin.

Yes, Spartacus checks the plugin version by version_compare($bag->get('version'), $data['version'], '<'),
but currently not the Serendipity version checks to only install plugins available for version, neither the PHP version.

The file plugins.inc.php checks all three [S9y, Php, Smarty](again, did any of you discovered this working for sure?), which looks good, but as using '>' for the check, in mean, that 'php' => '4.1.0' i.e., will proceed above this version only. For me this was new!

Does Spartacus eventually overwrite the plugins.inc.file settings in this part?

Btw., I also found installer.inc.php using if ( version_compare(phpversion(), '4.1.2', '>=') ), which should be 5.2.6 (or something better) in trunc or should we be secure and say 5.3.8 and up only (5.2 Series stopped being supported with August'11)?

from serendipity.

Hi!

I think PHP 5.2.6 should be enough, many debian packages/servers still
have that. But I don't know which version Smarty requires; I think
that's the most up to date component; the s9y core parts might even only
require PHP 5.0.0. :-)

Using >= also would be more properly; I think plugins.inc.php is the
proper place where this is checked.

I'm on vacation next week, if you remind me after that, I'll try to have
a thorough look on this.

Regards,
Garvin

On 18.01.2012 10:18 , Ian wrote:

Well, thank you responding, Garvin.

Yes, Spartacus checks the plugin version by

version_compare($bag->get('version'), $data['version'], '<')

but currently not the Serendipity version checks to only install plugins
available for version, neither the PHP version.

The file plugins.inc.php checks all three [S9y, Php, Smarty](again, did
any of you discovered this working for sure?), which looks good, but as
using '>' for the check, in mean, that 'php' => '4.1.0' i.e., will
proceed above this version only. For me this was new!

Does Spartacus eventually overwrite the plugins.inc.file settings in
this part?

Btw., I also found installer.inc.php using

if ( version_compare(phpversion(), '4.1.2', '>=') )

which should be 5.2.6 (or something better) in trunc or should we be
secure and say 5.3.8 and up only (5.2 Series stopped being supported
with August'11)?

---

Reply to this email directly or view it on GitHub:
#2 (comment)

from serendipity.

Yes, I'll do so - maybe I do switch the upgrade version already - have a
look into commit list when back.

Yes, Spartacus checks the plugin version by
but currently not the Serendipity version checks to only install plugins
available for version, neither the PHP version.

I just had another look and am not sure about this any more...
I'll keep this for you! :-)

from serendipity.

@garvinhicking
just a reminder for the spartacus todo list thing! ;-)

The PHP upgrade version thing is already trunked, hope that was all to do.

from serendipity.

Is this still open?

from serendipity.

I don't know... The required php version to install Serendipity ist set already and OK.
But the other question regarding spartacus plugin requirement checks might still need a closer lookup and also
https://github.com/s9y/Serendipity/blob/master/include/admin/plugins.inc.php#L380 (but this is a minor possibly...)

from serendipity.

We should probably open a seperate issue for the Spartacus plugin requirements checks and close this one.

from serendipity.

I don't understand this issue to the extent that I'm not even able to label it properly. o_O

Is this still open and what exactly is/are the issue(s) still to be addressed here?

from serendipity.

I disabled the s9y version note - @garvinhicking what about the need for a closer lookup of
https://github.com/s9y/Serendipity/blob/master/include/admin/plugins.inc.php#L380 note, to have this issue closed properly?

from serendipity.

Paging @garvinhicking …

from serendipity.

I'll close this for now. It is probably wise to create a specific issue for the smarty cersion check, if someone wants this feature.

from serendipity.