s9y / serendipity Goto Github PK

The comments block would be definitely better to show pending comments only.

Hi

Is this part
- Perform Serendipity version checks to only install plugins available for version
of the header todo list still an issue ? If yes, we should proceed to have it, as we have in short serendipity version only templates as 2k11 and plugins like (no, I won't tell ya :-) )!

If it is build-in already, did anyone really see it it working (for templates and plugins) for sure?

Just as a reminder
http://board.s9y.org/viewtopic.php?f=10&t=19115&p=10433439#p10433439

After saving an entry, S9y shows a status message in the iframe. It contains a broken image.

3 notes on commit d969624 Show line notes below

ophian commented on d969624

To all. Please keep an eye on this, since I had to do this manually. So there may be glitches hidden!
I am not sure if this can easily be ported by a cherry-pick to 2.0. Any thoughts on this?

ophian commented on d969624

@garvinhicking @yellowled and others
Did you get these changes about 2 weeks ago?

How can we merge and upport this into 2.0, since there have been tweaks to some plugins, which are 2.0 only?
I do not want to run that work again manually.

yellowled commented on d969624

Yes, got them.

Erm, we leave this to git merge? At some point, we're going to have to merge master into 2.0 or vice versa anyway. Also, could we please not discuss this here? This page takes forever to load due to the high number of files committed.

Hi ✨

Before I set it to ON...
Are there any scenarios in the wild which could keep us away using Smarty's own $config_booleanize class var in general?

"If set to TRUE, config files values of on/true/yes and off/false/no get converted to boolean values automatically. This way you can use the values in the template like so: {if #foobar#}...{/if}. If foobar was on, true or yes, the {if} statement will execute. Defaults to TRUE. "

🍅 🍅 🍅

The quicksearch plugin is supposed to be suppressed by 2k11's sidebar.tpl, which doesn't seem to work in 2.0 any longer.

2k11's sidebar.tpl uses {if $item.class != "serendipity_quicksearch_plugin"}…{/if} for this – any ideas (maybe related to Smarty 3?) why this wouldn't work any longer?

/serendipity_admin.php?serendipity[adminModule]=plugins
does not show the Update sidebar plugins Update event plugins links.

Comments pending to moderate, could need some colour, button, space, or something to make them more unique compared to approved comments.

grrr cccccccccccccc!

to avoid non stackable plugins being installed to more than one instance on manually pushed page reloads (eg because of an error).

Please read
http://board.s9y.org/viewtopic.php?f=11&t=19454&p=10436054#p10436054

Replace the details element for comment data with e.g. an interface similar to the extra info in configuration.

Currently, 2k11 uses web-fonts from google as an external http-source.

[...]
link  rel="stylesheet" href="http://fonts.googleapis.com/css?family=Droid+Sans:400,700"
[...]

Would it be possible to change this to https or make it optional within settings?

We need to backport things to the 1.6(.1) branch. Is there any other advice doing this via simple

git checkout 1.6
git cherry-pick <commit from master>

?

Should we also care doing this if we think it is necessary, or does Garvin remember all these commits, which might be good to have with a bugfix release? I personally would like to know, how this could be handled in a good manner.

• Create category
• Install new … plugin

• Check for hard-coded lang constants in template files. Those should be marked {* i18n *} (hopefully). Replace with existing lang constants if possible.
• Create new lang constants for those which can not be replaced with existing lang constants.
• Check for redundant lang constants (e.g. unused in 2.0 backend).
• Check for unneccessary verbose lang constants and shorten where possible (e.g. "This entry is not yet published." → "Unpublished.")
• Check for spelling errors in lang constants.
• Check installer/upgrader messages for color references which might have changed (yellow/blue) in 2.0 backend.

Mit Label

Theme options → Pick image from media db does not open in Magnific Popup

I think it would be nice to title the default template 2k11 as default in the theme section, like "2k11 (default)". Also a (i) button to describe the fallback mode could be something nice to have...
Is 2k11 already set as the default (standard) template?

And btw, is there a decision yet which templates will be delivered by release?
And what does MT mean, exactly? ;-)

• Change “Reactions” menu section to “Activity”
• Add new icon font build including icon-download

Since the 2.0 adds and (re)moves a lot of files, we might want to add a “clean up” function to the updater or provide it as a seperate script.

This would remove deprecated files from installations updated to 2.0 after a successful update. (Also for plugins and templates removed from the core, which seems likely to be part of the 2.0 release.)

Reply to comment link (in Comments section and Dashboard) should open in an overlay window (like e.g. Media library popup).

• serendipity_event_entryproperties
• serendipity_event_karma
• serendipity_even_statistics

These are the plugins (currently) in the core which create their own section in the backend (serendipity_event_entryproperties actually creates a section and subsections in existing sections, e.g. "New entry"). The markup of these sections needs to be adapted to the coding guidelines of the 2.0 backend to keep a consistent user interface.

Pull request #56 introduces improved stylesheet caching. Quoting @smoeding

Therefore the style sheet will be downloaded again after one hour. This is probably
redundant since the style sheet does not change that often.

Well, I see a scenario where the stylesheet changes much more often than that: (theme) development. So it would be nice to have a development/production switch of some kind. (Yes, I realize there's ways to circumvent caching in the browser, but it would be way more convenient with a central switch.)

I think this could i.e. also switch off minification of CSS/JS which we're planning to add to 2.0 as well.

Edit entries → category selector does not remember multiple categories (cookies?)

The CK Editor (or maybe any wysiwyg editor? needs testing) does not spawn in the HTML nugget sidebar plugin in the backend.

Uncaught ReferenceError: CKEDITOR is not defined 

Quest: What about checksum check for security?
Answ.: Checksum-checks could be added, but of course this is some work to implement...

Anyone?

The “Block this … via Spamblock plugin” buttons in the Comments section of the backend react sluggish at best.

@onli once mentioned this might have something to do with the page (not) being reloaded …?

Use buttons and links where appropriate (links to go to new places, buttons to do stuff)

If in the comment form I change the form url to an article ID not existing in my database (for example using FireBug) and then comment on that (not existing) article, the comment is declined.
But a mail is send out telling about a new comment!

Forum Post (German, sorry): http://board.s9y.org/viewtopic.php?f=10&t=18683&p=10431062#p10431062

serendipity_admin.php was the easiest place to grab the error.

This was from 1.7 alpha in the master branch. A similar failure occurs with the 1.6 branch.

== TESTING ERROR MODE ==

Fatal error: Uncaught exception 'ErrorException' with message 'Serendipity error: session_start(): open(/var/lib/php/session/sess_06kqcv177t9hnbanqh3he8fbu7, O_RDWR) failed: Permission denied (13)' in /var/www/html/include/compat.inc.php on line 106

ErrorException: Serendipity error: session_start(): open(/var/lib/php/session/sess_06kqcv177t9hnbanqh3he8fbu7, O_RDWR) failed: Permission denied (13) in /var/www/html/include/compat.inc.php on line 106

Call Stack:
0.0001 630664 1. {main}() /var/www/html/serendipity_admin.php:0
0.6072 1924952 2. serendipity_session_destroy() /var/www/html/serendipity_admin.php:33
0.6072 1924784 3. session_start() /var/www/html/include/functions_config.inc.php:364
0.6072 1925688 4. errorToExceptionHandler() /var/www/html/include/functions_config.inc.php:364

== TESTING ERROR MODE ==

Fatal error: Uncaught exception 'ErrorException' with message 'Serendipity error: Unknown: open(/var/lib/php/session/sess_06kqcv177t9hnbanqh3he8fbu7, O_RDWR) failed: Permission denied (13)' in /var/www/html/include/compat.inc.php on line 106

ErrorException: Serendipity error: Unknown: open(/var/lib/php/session/sess_06kqcv177t9hnbanqh3he8fbu7, O_RDWR) failed: Permission denied (13) in /var/www/html/include/compat.inc.php on line 106

Call Stack:
0.6076 1845080 1. errorToExceptionHandler() /var/www/html/include/compat.inc.php:0

Running the 1.6 release (not updated from HEAD in github)

Published entries show up as "This Entry is not yet Published".

This happens for posts created and published immediately as well as posts saved as a Draft and published later.

I'm not sure if this happens for scheduled posts as well but I assume it does.

Perhaps this has something to do with a server time in UTC?

Post date: 2012-03-21 16:36
Local date: Wed Mar 21 19:03:31 EDT 2012
Server date: Wed Mar 21 23:03:55 UTC 2012

I don't know if this helps:

mysql> select id,timestamp,isdraft,last_modified from serendipity_entries where id=4656;
+------+------------+---------+---------------+
| id | timestamp | isdraft | last_modified |
+------+------------+---------+---------------+
| 4656 | 1332416040 | false | 1332370564 |
+------+------------+---------+---------------+
1 row in set (0.00 sec)

mysql> select * from serendipity_config where name like "%serverOffsetHours%";
+-------------------+-------+----------+
| name | value | authorid |
+-------------------+-------+----------+
| serverOffsetHours | -4 | 0 |
+-------------------+-------+----------+
1 row in set (0.00 sec)

The buttons for filters etc. in the 2.0 backend should have some kind of state indicator. The easiest solution is probably to just assign them :active via JS.

Once the backend is ready for alpha (in other words “almost done”), we should check if the breakpoints used for responsive layout actually fit here.

As of now, we use pretty much typical standard breakpoints:

• min-width: 480px (smartphone/landscape)
• min-width: 640px (large smartphone displays or e.g. Kindle)
• min-width: 768px (tablet/portrait)
• min-width: 1024px (netbook)
• min-width: 1280px (laptop)
• min-width: 1600px (large desktop screens)

I assume that at least the netbook breakpoint needs to be lowered to 900px.

Please help testing, if Serendipity and plugins are affected by a change in output buffer handling. Apparently there was a change in PHP 5.4 which makes ob_end_clean() no longer passing the buffer to the callback function, registered using ob_start() and instead passes an empty string. People say, nothing will be displayed, ending with a blank page.

Is any using a current PHP to test this? I am not sure if this happens in our simple Serendipity and i.e. staticpage cases, else we would need to use ob_flush or use

if (version_compare(PHP_VERSION, "5.4", "<")) {
    ob_end_clean();
}

Please read
http://board.s9y.org/viewtopic.php?f=10&t=19214

Could be easily allowed by spamblock comment check to pass by...

The Add media upload form should include the previously removed functionality for

• hotlinking images
• downloading images
• and still combine those three in a tidy interface (tabs?)

In the media library's Media keywords filter, clicking the keywords should insert them into the corresponding input.

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md

There isn't really a need for this, since it all works like this as well. But we may discuss that here for 2.0 too.

We have two options to generate a preview. Go to Edit entries and …

A. … click the preview icon
B. … click Edit and then Preview in the entry editor

B always includes the backend stylesheet in the iframe, no matter what the entry status is. A includes the backend stylesheet for unpublished entries and drafts (but not for published entries.

I assume this is somehow related to $head_link_stylesheet because that's what preview_iframe.tpl references.

In the media library popup/overlay window

• get rid of the internal frameset
• replace Yahoo treeview by jqTree (or our own solution)
• also open the media libary popup in overlay window if not using wysiwyg editor
• adapt layout in media db overlay
• adapt size of media db overlay

Happy new Year to all of you

You might have noticed that something is missing in the current briefing of organization members. There are no email-notifications for commits and keeping track of real changes is difficult, especially for larger organizations or being a member of some, as you have to check in to the website permanentely. (There are commit hooks, and one of them is email, but only one email address can be provided, users can't choose to listen or not, like all the other notifications.) Commits show up only in the news feed or by adding a comment to each pushed commit. First is bad as you have email and/or news feed to look up for; the Second expects some extra work by any pushing collaborator.

There have been others wishing this feature, like:
http://stackoverflow.com/questions/552360/git-push-email-notification
which leads to some scripts enabling commit notifications. (there are more out there)

As I am still far away to understand all the official or hidden gems of gitting, I started to know about Git having a way to fire off custom scripts when certain important actions occur. There are two groups of these hooks: client side and server side. The client-side hooks are for client operations such as committing and merging. The server-side hooks are for Git server operations such as receiving pushed commits.

In our case we need to use something like the server-side POST-recieve Hook to execute a commit mailing list script, right?
This has to be filled with all push/pull collaborator email adresses, unless someone does not want it and off we go.
The script can be be customized to show more or less detailed commit statements.

Is that possible, Garvin? Is it worth to add it to s9y/repo org? And are all other Collaborators willing to have that?

Ian
(and here my knowledge currently stops, so don't ask me to do this ... )

If you call weblog-view with http://www.example.com/serendipity/index.php?/frontpage (like it is written in german manual) and go to "next page", url is resolved to /frontpage/archives/P???.html and an sql-error is shown.

If you call http://www.example.com/serendipity/index.php/frontpage (withount ?), it is resolved to /archives/P???.html and everything is fine, no sql-errors.

If you call /index.php?frontpage everythink is fine too.

Currently i am using Serendipity 1.7.1 daily build from 2013-05-29

When trying to preview an entry in the new backend, I get the following error:

Fatal error: Call to a member function assignByRef() on a non-object in /var/www/virtual/netzg/nbe.netzgestaltung.net/include/functions_entries.inc.php on line 1228

Could it be, that there is missing an ?> at the end of the file?

As of now, it states “$USERNAME (255)” where it should be “$USERNAME (Admin)” (in Manager users section).

According to that g2embed plugin thread in the forum, we should make use of namespace and bumb needed PHP version to some 5.3.x.

It does

#SPAMDENY
Deny from ip1 ip2 ip3 ip4 ip5 ip6 ... ipn
#/SPAMDENY

If the line get's too long, apache fails parsing it, which results in Internal Server Errors.

So, a better approach might be:

#SPAMDENY
Deny from ip1
Deny from ip2
...
Deny from ipn
#/SPAMDENY

Here's a patch that tries to accomplish this, it's not very well tested, so no pull request:

diff --git a/plugins/serendipity_event_spamblock/serendipity_event_spamblock.php b/plugins/serendipity_event_spamblock/serendipity_event_spamblock.php
index e83a2af..924c74a 100644
--- a/plugins/serendipity_event_spamblock/serendipity_event_spamblock.php
+++ b/plugins/serendipity_event_spamblock/serendipity_event_spamblock.php
@@ -467,9 +467,15 @@ var $filter_defaults;
                 // Check if an old htaccess file existed and try to preserve its contents. Otherwise completely wipe the file.
                 if ($htaccess != '' && preg_match('@^(.*)#SPAMDENY.*Deny From.+#/SPAMDENY(.*)$@imsU', $htaccess, $match)) {
                     // Code outside from s9y-code was found.
-                    $content = trim($match[1]) . "\n#SPAMDENY\nDeny From " . implode(' ', $deny) . "\n#/SPAMDENY\n" . trim($match[2]);
+                    $content = trim($match[1]) .
+                        "\n#SPAMDENY\n".
+                        implode("\n", array_map( function($ip) { return "Deny From ".$ip; }, $deny )).
+                        "\n#/SPAMDENY\n" . trim($match[2]);
                 } else {
-                    $content = trim($htaccess) . "\n#SPAMDENY\nDeny From " . implode(' ', $deny) . "\n#/SPAMDENY\n";
+                    $content = trim($htaccess) .
+                        "\n#SPAMDENY\n".
+                        implode("\n", array_map( function($ip) { return "Deny From ".$ip; }, $deny )).
+                        "\n#/SPAMDENY\n";
                 }
                 fwrite($fp, $content);
                 fclose($fp);

Plugin superuser is gone.... and its link in frontend sidebar.
Is that anything which was done by accident?

Edit: Talking about our testblog.

please read
http://board.s9y.org/viewtopic.php?f=3&t=19394