Discuss use of strict PSR coding standards about serendipity HOT 6 CLOSED

I wouldn't want to reformat all files to PSR-2, even though there are tools for this. But we could use this coding standard for any new things (whatever that means). I adhere to PSR-2 in more or less all my personal projects and think that it makes code more readable.

from serendipity.

I'm a fan of coding style guides in teams, I use editorconfig, and most of this doesn't concern me anyway since it's PHP only.

But.

I don't know if this is “common sense” among PHP coders or actually pretty strict. However, as a small project which could always use more help, we might always want to consider that this might scare off people from working on S9y. I'm not sure if the benefits of a coding style guide like this outweigh the possibility of limiting our developer base.

from serendipity.

Ah - nice tool, didn't know that, Thanks YL,

I agree to all said. I just wanted to have that starting to get discussed and may be forwarded into future.

from serendipity.

In the BOOK it says on page 699

Grundsätzlich sollten Sie sich bei der Programmierung an die PEAR-Coding-Standards halten.

So, up to now we actually already had coding standards, although Garvin didn't enforce them too strictly. Which is a good thing for the reasons mentioned above. Nevertheless, they could serve as guidelines on how to write cleaner code. I totally don't like the PEAR coding standards, but I at least tried to follow them a little bit ;)

Oh, and concerning tools, every decent IDE should have a setting to enable coding standards imho…

from serendipity.

The point about editorconfig is that editors and IDEs supporting it can just read the .editorconfig file of a project to set all the relevant settings without any manual tweaking. It is quite comfortable, albeit completely useless if someone uses an editor or IDE which doesn't support it.

from serendipity.

Let's close this for the time being and discuss it in the next devsprint.

from serendipity.