Comments (5)
I should probably say first that I'm not really a big fan of that line of thought. When confronted with the breakpoint-issue, I always tried to simply look at the specific page, look at it in the specific resolution and then decide which elements should be hidden or converted into more appropriate solutions.
That said, if we have a specific element that doesn't work well at the moment as it gets converted too early, that would of course mean that I'm all for just changing the breakpoint.
from serendipity.
Maybe the issue text doesn't explain it properly enough. This is not about showing/hiding elements. It's about layout, and not about layout in general, but very specific parts of it.
The issue at hand is the layout for the filters in the media database, or better: the way the filters are aligned next to each other if the screen is wide enough. They are in a linear view up until 1024px, starting with that, there's three filters next to each other.
Now, if you open the media database popup, this popup has a fixed width of 900px and it contains an iframe
in which the same @media
queries apply as in the “normal” backend. So because the popup is only 900px wide, the 1024px-min-width layout is not applied there, which means the filters are aligned in a linear view, although the available space in the popup would suffice for the 3-column view. And here's the point of it all: It might also suffice in the backend view of the media database through the corrensponding nav item. In that case, the 1024px breakpoint would be too high for this specific part of the layout.
I do not want to change the breakpoints altogether, just want to make sure I have chosen the right ones. It is usually better to not just use the standard breakpoints. Those are usually related to specific devices and their orientation modes. It's better to pick the breakpoints according to the width at which the layout demands a breakpoint.
from serendipity.
It's better to pick the breakpoints according to the width at which the layout demands a breakpoint.
Perfect, that is how I see it.
To the specific issue with the media popup: I had a look at it, and I think that given the small height of the popup, it would be better if the empty space in the filter view would be used. Maybe that would be an option for an intermediate 2-column-layout?
from serendipity.
That's just what I mean, but I think it will work if I just “move” the 3-column layout to a smaller breakpoint. I'll try that tomorrow.
from serendipity.
The “secondary” breakpoint is only needed to solve the filters layout in the media database overlay, but it works just as well in non-overlay screen resolutions.
from serendipity.
Related Issues (20)
- when could we use Serendipity 2.4-beta1 HOT 4
- serendipity_plugin_comments/: Fatal error: Uncaught TypeError: mb_strrpos(): HOT 3
- Upgrade bundled michelf/php-markdown in serendipity_event_markdown for PHP > 8.0 compatibility HOT 11
- Warning: Undefined array key "entries" in * HOT 6
- function strftime is deprecated (php 8.1) HOT 5
- 'Undefined array key "id"' warning in comments.tpl.php on preview with PHP 8 HOT 1
- [serendipity_event_twitter] feature request: support fediverse HOT 1
- Translation
- Translation HOT 1
- Uncaught ArgumentCountError: 4 arguments are required, 2 given in [path]/plugins/serendipity_event_spamblock/serendipity_event_spamblock.php:1070 HOT 3
- Much stronger defenses needed against aggressive persistent comment-spamming HOT 6
- Serendipity 2.4.0 version does not work on PHP 7.0 HOT 2
- Quicksearch vanishes HOT 4
- s9y current master: language constants already defined HOT 15
- PHP 8.1/8.2 warnings and errors HOT 2
- serendipity_event_multilingual: not compatible with PHP 8 HOT 9
- Javascript-Library broken? HOT 9
- New directory of sub-directory is not getting showed HOT 2
- Net_DNS2 from 2.4.0 is not compatible with PHP8 HOT 5
- fatal error for strftime with comments HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serendipity.