sabhiram / go-gitignore Goto Github PK

First of all thanks for the great work 👍

I'll use go-gitignore in one of my projects and would be nice if the project follows semver tagging style.

Is it possible to append more lines to a GitIgnore struct?

Could be solved by adding a function to merge multiple GitIgnore structs

func MergeGitIgnores(gitIgnores ...*GitIgnore) *GitIgnore

Hi! Quoting the gitignore spec:

An asterisk "*" matches anything except a slash.

Currently, the * walks right over any slashes. See the following example, which uses the common .* pattern to ignore dotfiles (used, for example, by the linux source). None of the paths should match.

package main

import (
	"fmt"

	"github.com/sabhiram/go-gitignore"
)

func main() {
	ign := ignore.CompileIgnoreLines(".*")
	paths := []string{
		"/a/b/.c/",
		"/.foo/a",
	}
	for _, p := range paths {
		matches := ign.MatchesPath(p)
		fmt.Printf("%q - %v\n", p, matches)
	}

	ign2 := ignore.CompileIgnoreLines("/.*")
	paths2 := []string{
		".foo/a",
		".asd/"}
	for _, p := range paths2 {
		matches := ign2.MatchesPath(p)
		fmt.Printf("%q - %v\n", p, matches)
	}
}

@sabhiram do you still maintain this project? Will pull requests be reviewed? I'd be happy to help out with this problem.

👋🏻

I'm trying to support .gitignore from the current directory as well as the user's global git ignore (which I'm parsing from ~/.gitconfig's core.excludesfile field).

Specifically I want to support whatever is defined in the local .gitignore and also whatever is in the global one.

The only way I think I'll be able to do that is by using CompileIgnoreFileAndLines and passing in the local file for the first argument, and then doing a ReadFile/Split for the global git ignore file and passing the individual lines.

Would that sound like the right approach to take or would you suggest any other way to achieve this?

Thanks!

Looks like travis ci is no longer free since a month (june 15 2021)
Move to something like github actions or circle ci etc?

#16

Hi, thank you for the library! I noticed that 223ce5d changed the API.

Would you consider releasing v2.0 to mark the API change?

"io/ioutil" is deprecated: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.deprecated(default)

In CompileIgnoreLines (here), the function includes an error, when there is no actual error case returned. That then forces following methods (like CompileIgnoreFile) to also return a possible error, when none is possible.

Shouldn't the function call be:

func CompileIgnoreLines(lines ...string) *GitIgnore {

?

looks like they are probably going to be implemented based on MatchesPath

the file is called gitignore, didn't find this library for a while because of the name

Pattern: "?bc"
Path: "abc"
Expected to match, it doesn't

So I'm suggesting one more sibling method for MatchesPath which should kind of function like

git check-ignore -v filename

i.e. It would be cool if it can return

• Which of the patterns matches with it (should be easy to implement right now)
• Where the pattern was defined in the .gitignore file (needs a lot of work I assume)