ecar's People
Forkers
gmaslowskiecar's Issues
Final fields, wherever it is possible
ServiceSpec is beyond reason for all of tests
Take a look at ReflectionUtilities and FeatureProxyFactoryBean
Don't thik it is overeenginerring
@Rollback is redundant
Entity and ReflectionUtilities (it is so obvious you duplicated this)
Order of private and public methods
One case for one validation phase
More classes, each of them should check only one case
Controllers should be moved from adapters to infrastructure
Test configuration must be moved to groovy
Functional tests CustomerSpec should not have calculator functionality
ErrorDto must be close to ErrorHandler
MapBasedCalculator, OverlapBasedCalculator must be cleaner
Calculate method must be changed to use factory rather than construct
REST, unnecessary plural
I don't think so, I did not implemented delete a customer or delete a price. I did implement delete all.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.