safient / contract-js Goto Github PK

Description:

The contract should verify the safe creator address by verifying the safe creation proof signature.

Description:

Update the create claim API to return block.timestamp

Description:

Update the file names of SDK and contract tests and place them on different directories

Things to do:

• Rename the test files and directories
• Remove the test dependencies by using before, after statements

Expected outcome:

Repeated test runs shouldn't fail.

Description:

Update the configs and hard hat tasks to support deployments to other networks.

Things to do:

• Update hardhat.config.js to include all the tenets (Ethereum and Polygon) and mainnet
• Add generate and account hardhat tasks
• Update the networks.json to include the deployed addresses

Expected outcome:

Able to deploy the required contracts on testnet

Description:

The client doesn't get the proper endpoint of the provider due to environment variable issue

Description:

Best practices for security and readability of contracts

Things to do:

• Add safeMath and secure fund transfer interfaces
• Add ownable concept
• Explore upgradeability approaches

Suggestions:

Description:

Add any missing docstrings for the APIs of SDK

Things to do:

• Cross check the docstring with Solidity API params
• Follow the type doc for comments (https://typedoc.org/guides/doccomments/)

Expected outcome:

• Should be able to generate the docs using doc comments

Description:

Add safe deprecation and updation feature for the creator.

• Reject claim creation if the safe is deprecated.
• Create a single method to update the safe info/ conditions.

Description:

Revert the claim creation instead of updating the claim status. Update the SDK and tests accordingly

Description:

Add a claim incentive functionality to withdraw partial or entire funds that were assigned after the safe recovery.

Things to do:

• Map the fund amount to the Safien (guardian) after the safe recovery proof submission
• Transfer the funds partially or entirely after invoking claimFunds.

Expected outcome:

• Only guardians should be able to claim their incentives

Description:

Create a new expiration-based claim method

• The claim method will take an expiration time stamp
• Allow the beneficiary to claim before the expiration time stamp
• Write new tests for the method

Description:

Allow only one safe incentivization execution at a time for a particular safe by adding execution status to the safe,

Description:

Deploy and update the Kovan testnet contract addresses in utils/network.json

Description:

Add a provider to calculate the time for DDaybased claim

Description:

Deploy the testnet version of contracts on Polygon Mumbai testnet (Chainid: 80001)

Description:

Update and redeploy the contract on Kovan testnet after the fix on #31

Description:

A safe claim can be created anytime before the D day but the claim will be passed only on the D day if and only if the D day is not canceled/ updated by the safe creator. The D day can be renewed anytime before the D day by the creator.

Things to do:

• Update safe creation and claim methods

Description:

Update the guardianProof API to return TransactionResponse instead of boolean

Description:

Rename the variables of structs and a few functions

Things to do:

• Rename claims and Safe struct variable
• Remove the period concept fo signaling
• Rename a few functions

Suggestions:

• Follow best practices for naming